commit 15247cd6159acf8692e70c561d8a91899420b366
author Chen-Yu Tsai <wenst@chromium.org> Mon Sep 27 10:37:28 2021 +0800
committer Commit Bot <commit-bot@chromium.org> Tue Sep 28 03:47:24 2021 +0000
tree 090c163b48896c2f736f2404f04ef322bc3e133d
parent ccf21e0676d54e7af77456c8015ffeb4c95a76a3

build_kernel_image: Use "==" instead of "=" in conditional expressions

'=' and '==' both express testing for equal strings within conditional
expressions. '=' is likely a carry-over from `test` and `[` style
checks, but might be confusing to people less familiar with bash shell
scripts.

Convert the existing '=' operators within conditional expressions to
'=='. Behavior should stay the same.

BUG=none
TEST=Run `build_kernel_image.sh --arch ${arch} ...` and check produced
     config.txt:
     contains "i915.modeset=1" for ${arch} = "x86" or "amd64",
     no "i915.modeset=1" for ${arch} in {"arm", "arm64", "mips"},
     Produces error "Unknown arch: XXX" for any other ${arch}

Change-Id: I40ad081bcb2e4fe04ed3fb7edf6f901fde099d38
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/3185521
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Commit-Queue: Chen-Yu Tsai <wenst@chromium.org>

build_kernel_image.sh

diff --git a/build_kernel_image.sh b/build_kernel_image.sh
index a05b260..63984cf 100755
--- a/build_kernel_image.sh
+++ b/build_kernel_image.sh
@@ -287,7 +287,7 @@
 drm.trace=0x106
 EOF
 
-if [[ "${FLAGS_arch}" = "x86" || "${FLAGS_arch}" = "amd64" ]]; then
+if [[ "${FLAGS_arch}" == "x86" || "${FLAGS_arch}" == "amd64" ]]; then
   # Legacy BIOS will use the kernel in the rootfs (via syslinux), as will
   # standard EFI BIOS (via grub, from the EFI System Partition). Chrome OS
   # BIOS will use a separate signed kernel partition, which we'll create now.
@@ -301,7 +301,7 @@
   WORK="${WORK} ${FLAGS_working_dir}/config.txt"
 
   bootloader_path="/lib64/bootstub/bootstub.efi"
-elif [[ "${FLAGS_arch}" = "arm" || "${FLAGS_arch}" = "mips"  || "${FLAGS_arch}" = "arm64" ]]; then
+elif [[ "${FLAGS_arch}" == "arm" || "${FLAGS_arch}" == "mips"  || "${FLAGS_arch}" == "arm64" ]]; then
   WORK="${WORK} ${FLAGS_working_dir}/config.txt"
 
   # arm does not need/have a bootloader in kernel partition