chrome-icu: fix some shellcheck warnings
And clean out some redundant code.
BUG=None
TEST=CQ passes
Change-Id: Ib3429547d32f5c15ac4d1c9ff15694d7860be95a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3791693
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gilberto Contreras <gcontreras@google.com>
Commit-Queue: Gilberto Contreras <gcontreras@google.com>
diff --git a/chromeos-base/chrome-icu/chrome-icu-9999.ebuild b/chromeos-base/chrome-icu/chrome-icu-9999.ebuild
index b3c398a..9658387 100644
--- a/chromeos-base/chrome-icu/chrome-icu-9999.ebuild
+++ b/chromeos-base/chrome-icu/chrome-icu-9999.ebuild
@@ -99,9 +99,7 @@
x11-libs/libdrm
"
-# [Mod] NaCl utilities are removed.
-
-usetf() { usex $1 true false ; }
+usetf() { usex "$1" true false ; }
set_build_args() {
# [Mod] 1. Add a new arg "icu_disable_thin_archive=true".
@@ -128,7 +126,6 @@
"use_debug_fission=false"
"enable_remoting=false"
"enable_nacl=false"
- "enable_nacl=false"
"icu_use_data_file=true"
# Add this to make xkbcommon handling identical with chromeos-chrome.
# This will make it more likely to catch potential xkbcommon related
@@ -552,8 +549,6 @@
[[ "${ret}" -eq 0 ]] || die
}
-# [Mod] src_compile() is simplied because 1) the case CHROME_LOCAL=LOCAL_BINARY
-# is excluded. 2) we do not need nacl or tests.
src_compile() {
cd "${CHROME_ROOT}"/src || die "Cannot chdir to ${CHROME_ROOT}/src"