commit 4d9248f989ecf29a4c3e5c525cccdacb7708e11f
author Steve French <stfrench@microsoft.com> Wed May 13 10:27:16 2020 -0500
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Wed Jun 03 08:19:30 2020 +0200
tree ab0ee8d474ab54c8025c0b25405534773fdc5e8a
parent 8b14d3efedb20c12e0fe9e3c43bb06f95e173c1e

cifs: Fix null pointer check in cifs_read

[ Upstream commit 9bd21d4b1a767c3abebec203342f3820dcb84662 ]

Coverity scan noted a redundant null check

Coverity-id: 728517
Reported-by: Coverity <scan-admin@coverity.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Shyam Prasad N <nspmangalore@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

fs/cifs/file.c

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index cfb0d91..128cbd6 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -3532,7 +3532,7 @@
 			 * than it negotiated since it will refuse the read
 			 * then.
 			 */
-			if ((tcon->ses) && !(tcon->ses->capabilities &
+			if (!(tcon->ses->capabilities &
 				tcon->ses->server->vals->cap_large_files)) {
 				current_read_size = min_t(uint,
 					current_read_size, CIFSMaxBufSize);