Crosperf: Mark benchmark run as failed if it contains no results.
Sometimes telemetry tests do not fail but results are empty.
In that case, mark the run as failed explicitly.
BUG=chromium:729634
TEST=Tested manually on failing lummpy nightly tests. The generated report shows
tests as failed as expected.
Change-Id: Ia52af887e81ed630d7578f9abe93f9656c70512b
Reviewed-on: https://chromium-review.googlesource.com/526392
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
diff --git a/crosperf/results_organizer.py b/crosperf/results_organizer.py
index b764185..bda0cc1 100644
--- a/crosperf/results_organizer.py
+++ b/crosperf/results_organizer.py
@@ -196,6 +196,7 @@
# (This can happen if, for example, the test has been disabled.)
if len(cur_dict) == 1 and cur_dict['retval'] == 0:
cur_dict['retval'] = 1
+ benchmark_run.result.keyvals['retval'] = 1
# TODO: This output should be sent via logger.
print(
"WARNING: Test '%s' appears to have succeeded but returned"