commit aebe42390cdd3f92a798b5250e98b240346347cd
author Manoj Gupta <manojgupta@google.com> Wed May 06 12:33:49 2020 -0700
committer Manoj Gupta <manojgupta@chromium.org> Wed May 06 20:00:41 2020 +0000
tree 37313c4f20560c7b00a0dda5bc08893e998911db
parent c3ef8fb837482ad60e05d3c7c0638970bc4d2578

llvm_tools: Remove unused verbose args

RunTryJobs does not take a verbose arg anymore. Fix
modify_a_tryjob.py to not pass it.

BUG=None
TEST=llvm_bisection works

Change-Id: Ief59aa5f8df2ed9364e506df2b066a02167ee6bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2185710
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

llvm_tools/modify_a_tryjob.py

diff --git a/llvm_tools/modify_a_tryjob.py b/llvm_tools/modify_a_tryjob.py
index 0d6b070..4d41e6b 100755
--- a/llvm_tools/modify_a_tryjob.py
+++ b/llvm_tools/modify_a_tryjob.py
@@ -135,7 +135,7 @@
 
 
 def CreateNewTryjobEntryForBisection(cl, extra_cls, options, builder,
-                                     chroot_path, verbose, cl_url, revision):
+                                     chroot_path, cl_url, revision):
   """Submits a tryjob and adds additional information."""
 
   # Get the tryjob results after submitting the tryjob.
@@ -150,7 +150,7 @@
   #   }
   # ]
   tryjob_results = update_packages_and_run_tests.RunTryJobs(
-      cl, extra_cls, options, [builder], chroot_path, verbose)
+      cl, extra_cls, options, [builder], chroot_path)
   print('\nTryjob:')
   print(tryjob_results[0])
 
@@ -173,9 +173,10 @@
                                            chroot_path, patch_metadata_file,
                                            svn_option)
 
-  tryjob_dict = CreateNewTryjobEntryForBisection(
-      change_list.cl_number, extra_cls, options, builder, chroot_path, verbose,
-      change_list.url, revision)
+  tryjob_dict = CreateNewTryjobEntryForBisection(change_list.cl_number,
+                                                 extra_cls, options, builder,
+                                                 chroot_path, change_list.url,
+                                                 revision)
 
   return tryjob_dict
 
@@ -219,8 +220,8 @@
 
   # 'FindTryjobIndex()' returns None if the tryjob was not found.
   if tryjob_index is None and modify_tryjob != ModifyTryjob.ADD:
-    raise ValueError(
-        'Unable to find tryjob for %d in %s' % (revision, status_file))
+    raise ValueError('Unable to find tryjob for %d in %s' %
+                     (revision, status_file))
 
   # Determine the action to take based off of 'modify_tryjob'.
   if modify_tryjob == ModifyTryjob.REMOVE:
@@ -272,8 +273,8 @@
     else:
       raise ValueError('Failed to add tryjob to %s' % status_file)
   else:
-    raise ValueError(
-        'Invalid "modify_tryjob" option provided: %s' % modify_tryjob)
+    raise ValueError('Invalid "modify_tryjob" option provided: %s' %
+                     modify_tryjob)
 
   with open(status_file, 'w') as update_tryjobs:
     json.dump(bisect_contents, update_tryjobs, indent=4, separators=(',', ': '))
@@ -286,11 +287,12 @@
 
   args_output = GetCommandLineArgs()
 
-  PerformTryjobModification(
-      args_output.revision, ModifyTryjob(
-          args_output.modify_tryjob), args_output.status_file,
-      args_output.extra_change_lists, args_output.options, args_output.builder,
-      args_output.chroot_path, args_output.verbose)
+  PerformTryjobModification(args_output.revision,
+                            ModifyTryjob(args_output.modify_tryjob),
+                            args_output.status_file,
+                            args_output.extra_change_lists, args_output.options,
+                            args_output.builder, args_output.chroot_path,
+                            args_output.verbose)
 
 
 if __name__ == '__main__':