src/drivers/intel/fsp1_1/raminit.c - mirrors/cros/chromiumos/third_party/coreboot - Git at Google

 /* SPDX-License-Identifier: GPL-2.0-only */

 #include <acpi/acpi.h>
 #include <cbmem.h>
 #include <cf9_reset.h>
 #include <commonlib/helpers.h>
 #include <console/console.h>
 #include <cpu/x86/smm.h>
 #include <fsp/romstage.h>
 #include <fsp/util.h>
 #include <lib.h>
 #include <string.h>
 #include <timestamp.h>

 void raminit(struct romstage_params *params)
 {
 	const bool s3wake = params->power_state->prev_sleep_state == ACPI_S3;
 	const EFI_GUID bootldr_tolum_guid = FSP_BOOTLOADER_TOLUM_HOB_GUID;
 	EFI_HOB_RESOURCE_DESCRIPTOR *cbmem_root;
 	FSP_INFO_HEADER *fsp_header;
 	EFI_HOB_RESOURCE_DESCRIPTOR *fsp_memory;
 	FSP_MEMORY_INIT fsp_memory_init;
 	FSP_MEMORY_INIT_PARAMS fsp_memory_init_params;
 	const EFI_GUID fsp_reserved_guid =
 		FSP_RESERVED_MEMORY_RESOURCE_HOB_GUID;
 	void *fsp_reserved_memory_area;
 	FSP_INIT_RT_COMMON_BUFFER fsp_rt_common_buffer;
 	void *hob_list_ptr;
 	FSP_SMBIOS_MEMORY_INFO *memory_info_hob;
 	const EFI_GUID memory_info_hob_guid = FSP_SMBIOS_MEMORY_INFO_GUID;
 	MEMORY_INIT_UPD memory_init_params;
 	const EFI_GUID mrc_guid = FSP_NON_VOLATILE_STORAGE_HOB_GUID;
 	u32 *mrc_hob;
 	u32 fsp_reserved_bytes;
 	MEMORY_INIT_UPD *original_params;
 	EFI_STATUS status;
 	VPD_DATA_REGION *vpd_ptr;
 	UPD_DATA_REGION *upd_ptr;
 	int fsp_verification_failure = 0;
 	EFI_PEI_HOB_POINTERS hob_ptr;
 	uintptr_t smm_base;
 	size_t smm_size;

 	/*
 	 * Find and copy the UPD region to the stack so the platform can modify
 	 * the settings if needed.  Modifications to the UPD buffer are done in
 	 * the platform callback code.  The platform callback code is also
 	 * responsible for assigning the UpdDataRngPtr to this buffer if any
 	 * updates are made.  The default state is to leave the UpdDataRngPtr
 	 * set to NULL.  This indicates that the FSP code will use the UPD
 	 * region in the FSP binary.
 	 */
 	post_code(POST_MEM_PREINIT_PREP_START);
 	fsp_header = params->chipset_context;
 	vpd_ptr = (VPD_DATA_REGION *)(fsp_header->CfgRegionOffset +
 					fsp_header->ImageBase);
 	printk(BIOS_DEBUG, "VPD Data: %p\n", vpd_ptr);
 	upd_ptr = (UPD_DATA_REGION *)(vpd_ptr->PcdUpdRegionOffset +
 					fsp_header->ImageBase);
 	printk(BIOS_DEBUG, "UPD Data: %p\n", upd_ptr);
 	original_params = (void *)((u8 *)upd_ptr +
 		upd_ptr->MemoryInitUpdOffset);
 	memcpy(&memory_init_params, original_params,
 		sizeof(memory_init_params));

 	/* Zero fill RT Buffer data and start populating fields. */
 	memset(&fsp_rt_common_buffer, 0, sizeof(fsp_rt_common_buffer));
 	if (s3wake) {
 		fsp_rt_common_buffer.BootMode = BOOT_ON_S3_RESUME;
 	} else if (params->saved_data != NULL) {
 		fsp_rt_common_buffer.BootMode =
 			BOOT_ASSUMING_NO_CONFIGURATION_CHANGES;
 	} else {
 		fsp_rt_common_buffer.BootMode = BOOT_WITH_FULL_CONFIGURATION;
 	}
 	fsp_rt_common_buffer.UpdDataRgnPtr = &memory_init_params;
 	fsp_rt_common_buffer.BootLoaderTolumSize = cbmem_overhead_size();

 	/* Get any board specific changes */
 	fsp_memory_init_params.NvsBufferPtr = (void *)params->saved_data;
 	fsp_memory_init_params.RtBufferPtr = &fsp_rt_common_buffer;
 	fsp_memory_init_params.HobListPtr = &hob_list_ptr;

 	/* Update the UPD data */
 	soc_memory_init_params(params, &memory_init_params);
 	mainboard_memory_init_params(params, &memory_init_params);

 	if (CONFIG(MMA))
 		setup_mma(&memory_init_params);

 	post_code(POST_MEM_PREINIT_PREP_END);

 	/* Display the UPD data */
 	if (CONFIG(DISPLAY_UPD_DATA))
 		soc_display_memory_init_params(original_params,
 			&memory_init_params);

 	/* Call FspMemoryInit to initialize RAM */
 	fsp_memory_init = (FSP_MEMORY_INIT)(fsp_header->ImageBase
 		+ fsp_header->FspMemoryInitEntryOffset);
 	printk(BIOS_DEBUG, "Calling FspMemoryInit: %p\n", fsp_memory_init);
 	printk(BIOS_SPEW, "    %p: NvsBufferPtr\n",
 		fsp_memory_init_params.NvsBufferPtr);
 	printk(BIOS_SPEW, "    %p: RtBufferPtr\n",
 		fsp_memory_init_params.RtBufferPtr);
 	printk(BIOS_SPEW, "    %p: HobListPtr\n",
 		fsp_memory_init_params.HobListPtr);

 	timestamp_add_now(TS_FSP_MEMORY_INIT_START);
 	post_code(POST_FSP_MEMORY_INIT);
 	status = fsp_memory_init(&fsp_memory_init_params);
 	mainboard_after_memory_init();
 	post_code(0x37);
 	timestamp_add_now(TS_FSP_MEMORY_INIT_END);

 	printk(BIOS_DEBUG, "FspMemoryInit returned 0x%08x\n", status);
 	if (status != EFI_SUCCESS)
 		die_with_post_code(POST_RAM_FAILURE,
 			"ERROR - FspMemoryInit failed to initialize memory!\n");

 	/* Locate the FSP reserved memory area */
 	fsp_reserved_bytes = 0;
 	fsp_memory = get_next_resource_hob(&fsp_reserved_guid, hob_list_ptr);
 	if (fsp_memory == NULL) {
 		fsp_verification_failure = 1;
 		printk(BIOS_ERR,
 			"7.2: FSP_RESERVED_MEMORY_RESOURCE_HOB missing!\n");
 	} else {
 		fsp_reserved_bytes = fsp_memory->ResourceLength;
 		printk(BIOS_DEBUG, "Reserving 0x%016lx bytes for FSP\n",
 			(unsigned long int)fsp_reserved_bytes);
 	}

 	/* Display SMM area */
 	if (CONFIG(HAVE_SMI_HANDLER)) {
 		smm_region(&smm_base, &smm_size);
 		printk(BIOS_DEBUG, "0x%08x: smm_size\n", (unsigned int)smm_size);
 		printk(BIOS_DEBUG, "0x%08x: smm_base\n", (unsigned int)smm_base);
 	}

 	/* Migrate CAR data */
 	printk(BIOS_DEBUG, "%p: cbmem_top\n", cbmem_top());
 	if (!s3wake) {
 		cbmem_initialize_empty_id_size(CBMEM_ID_FSP_RESERVED_MEMORY,
 			fsp_reserved_bytes);
 	} else if (cbmem_initialize_id_size(CBMEM_ID_FSP_RESERVED_MEMORY,
 		fsp_reserved_bytes)) {
 		printk(BIOS_DEBUG, "Failed to recover CBMEM in S3 resume.\n");
 		/* Failed S3 resume, reset to come up cleanly */
 		/* FIXME: A "system" reset is likely enough: */
 		full_reset();
 	}

 	/* Save the FSP runtime parameters. */
 	fsp_set_runtime(fsp_header, hob_list_ptr);

 	/* Lookup the FSP_BOOTLOADER_TOLUM_HOB */
 	cbmem_root = get_next_resource_hob(&bootldr_tolum_guid, hob_list_ptr);
 	if (cbmem_root == NULL) {
 		fsp_verification_failure = 1;
 		printk(BIOS_ERR, "7.4: FSP_BOOTLOADER_TOLUM_HOB missing!\n");
 		printk(BIOS_ERR, "BootLoaderTolumSize: 0x%08x bytes\n",
 			fsp_rt_common_buffer.BootLoaderTolumSize);
 	}

 	/* Locate the FSP_SMBIOS_MEMORY_INFO HOB */
 	memory_info_hob = get_next_guid_hob(&memory_info_hob_guid,
 		hob_list_ptr);
 	if (memory_info_hob == NULL) {
 		printk(BIOS_ERR, "FSP_SMBIOS_MEMORY_INFO HOB missing!\n");
 		fsp_verification_failure = 1;
 	}

 	if (hob_list_ptr == NULL)
 		die_with_post_code(POST_RAM_FAILURE,
 			"ERROR - HOB pointer is NULL!\n");

 	/*
 	 * Verify that FSP is generating the required HOBs:
 	 *	7.1: FSP_BOOTLOADER_TEMP_MEMORY_HOB only produced for FSP 1.0
 	 *	7.2: FSP_RESERVED_MEMORY_RESOURCE_HOB verified above
 	 *	7.3: FSP_NON_VOLATILE_STORAGE_HOB only produced when
 	 *	     new NVS data is generated, verified below
 	 *	7.4: FSP_BOOTLOADER_TOLUM_HOB verified above
 	 *	7.5: EFI_PEI_GRAPHICS_INFO_HOB produced by SiliconInit
 	 *	FSP_SMBIOS_MEMORY_INFO HOB verified above
 	 */
 	hob_ptr.Raw = get_next_guid_hob(&mrc_guid, hob_list_ptr);
 	if ((hob_ptr.Raw == NULL) && (params->saved_data == NULL)) {
 		printk(BIOS_ERR, "7.3: FSP_NON_VOLATILE_STORAGE_HOB missing!\n");
 		fsp_verification_failure = 1;
 	}

 	/* Verify all the HOBs are present */
 	if (fsp_verification_failure)
 		printk(BIOS_ERR,
 			"ERROR - Missing one or more required FSP HOBs!\n");

 	/* Display the HOBs */
 	if (CONFIG(DISPLAY_HOBS))
 		print_hob_type_structure(0, hob_list_ptr);

 	/* Get the address of the CBMEM region for the FSP reserved memory */
 	fsp_reserved_memory_area = cbmem_find(CBMEM_ID_FSP_RESERVED_MEMORY);
 	printk(BIOS_DEBUG, "%p: fsp_reserved_memory_area\n",
 		fsp_reserved_memory_area);

 	/* Verify the order of CBMEM root and FSP memory */
 	if ((fsp_memory != NULL) && (cbmem_root != NULL) &&
 		(cbmem_root->PhysicalStart <= fsp_memory->PhysicalStart)) {
 		fsp_verification_failure = 1;
 		printk(BIOS_ERR,
 			"ERROR - FSP reserved memory above CBMEM root!\n");
 	}

 	/* Verify that the FSP memory was properly reserved */
 	if ((fsp_memory != NULL) && ((fsp_reserved_memory_area == NULL) ||
 		(fsp_memory->PhysicalStart !=
 			(unsigned int)fsp_reserved_memory_area))) {
 		fsp_verification_failure = 1;
 		printk(BIOS_ERR, "ERROR - Reserving FSP memory area!\n");

 		if (CONFIG(HAVE_SMI_HANDLER) && cbmem_root != NULL) {
 			size_t delta_bytes = smm_base
 				- cbmem_root->PhysicalStart
 				- cbmem_root->ResourceLength;
 			printk(BIOS_ERR,
 				"0x%08x: Chipset reserved bytes reported by FSP\n",
 				(unsigned int)delta_bytes);
 			die_with_post_code(POST_INVALID_VENDOR_BINARY,
 				"Please verify the chipset reserved size\n");
 		}
 	}

 	/* Verify the FSP 1.1 HOB interface */
 	if (fsp_verification_failure)
 		die_with_post_code(POST_INVALID_VENDOR_BINARY,
 				   "ERROR - coreboot's requirements not met by FSP binary!\n");

 	/* Locate the memory configuration data to speed up the next reboot */
 	mrc_hob = get_next_guid_hob(&mrc_guid, hob_list_ptr);
 	if (mrc_hob == NULL) {
 		printk(BIOS_DEBUG,
 			"Memory Configuration Data Hob not present\n");
 	} else {
 		params->data_to_save = GET_GUID_HOB_DATA(mrc_hob);
 		params->data_to_save_size = ALIGN_UP(
 			((u32)GET_HOB_LENGTH(mrc_hob)), 16);
 	}
 }

 /* Initialize the UPD parameters for MemoryInit */
 __weak void mainboard_memory_init_params(
 	struct romstage_params *params,
 	MEMORY_INIT_UPD *upd_ptr)
 {
 	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
 }

 /* Display the UPD parameters for MemoryInit */
 __weak void soc_display_memory_init_params(
 	const MEMORY_INIT_UPD *old, MEMORY_INIT_UPD *new)
 {
 	printk(BIOS_SPEW, "UPD values for MemoryInit:\n");
 	hexdump32(BIOS_SPEW, new, sizeof(*new));
 }

 /* Initialize the UPD parameters for MemoryInit */
 __weak void soc_memory_init_params(
 	struct romstage_params *params,
 	MEMORY_INIT_UPD *upd)
 {
 	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
 }

 /* Initialize the SoC after MemoryInit */
 __weak void mainboard_after_memory_init(void)
 {
 	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
 }
	/* SPDX-License-Identifier: GPL-2.0-only */

	#include <acpi/acpi.h>
	#include <cbmem.h>
	#include <cf9_reset.h>
	#include <commonlib/helpers.h>
	#include <console/console.h>
	#include <cpu/x86/smm.h>
	#include <fsp/romstage.h>
	#include <fsp/util.h>
	#include <lib.h>
	#include <string.h>
	#include <timestamp.h>

	void raminit(struct romstage_params *params)
	{
	const bool s3wake = params->power_state->prev_sleep_state == ACPI_S3;
	const EFI_GUID bootldr_tolum_guid = FSP_BOOTLOADER_TOLUM_HOB_GUID;
	EFI_HOB_RESOURCE_DESCRIPTOR *cbmem_root;
	FSP_INFO_HEADER *fsp_header;
	EFI_HOB_RESOURCE_DESCRIPTOR *fsp_memory;
	FSP_MEMORY_INIT fsp_memory_init;
	FSP_MEMORY_INIT_PARAMS fsp_memory_init_params;
	const EFI_GUID fsp_reserved_guid =
	FSP_RESERVED_MEMORY_RESOURCE_HOB_GUID;
	void *fsp_reserved_memory_area;
	FSP_INIT_RT_COMMON_BUFFER fsp_rt_common_buffer;
	void *hob_list_ptr;
	FSP_SMBIOS_MEMORY_INFO *memory_info_hob;
	const EFI_GUID memory_info_hob_guid = FSP_SMBIOS_MEMORY_INFO_GUID;
	MEMORY_INIT_UPD memory_init_params;
	const EFI_GUID mrc_guid = FSP_NON_VOLATILE_STORAGE_HOB_GUID;
	u32 *mrc_hob;
	u32 fsp_reserved_bytes;
	MEMORY_INIT_UPD *original_params;
	EFI_STATUS status;
	VPD_DATA_REGION *vpd_ptr;
	UPD_DATA_REGION *upd_ptr;
	int fsp_verification_failure = 0;
	EFI_PEI_HOB_POINTERS hob_ptr;
	uintptr_t smm_base;
	size_t smm_size;

	/*
	* Find and copy the UPD region to the stack so the platform can modify
	* the settings if needed. Modifications to the UPD buffer are done in
	* the platform callback code. The platform callback code is also
	* responsible for assigning the UpdDataRngPtr to this buffer if any
	* updates are made. The default state is to leave the UpdDataRngPtr
	* set to NULL. This indicates that the FSP code will use the UPD
	* region in the FSP binary.
	*/
	post_code(POST_MEM_PREINIT_PREP_START);
	fsp_header = params->chipset_context;
	vpd_ptr = (VPD_DATA_REGION *)(fsp_header->CfgRegionOffset +
	fsp_header->ImageBase);
	printk(BIOS_DEBUG, "VPD Data: %p\n", vpd_ptr);
	upd_ptr = (UPD_DATA_REGION *)(vpd_ptr->PcdUpdRegionOffset +
	fsp_header->ImageBase);
	printk(BIOS_DEBUG, "UPD Data: %p\n", upd_ptr);
	original_params = (void )((u8 )upd_ptr +
	upd_ptr->MemoryInitUpdOffset);
	memcpy(&memory_init_params, original_params,
	sizeof(memory_init_params));

	/* Zero fill RT Buffer data and start populating fields. */
	memset(&fsp_rt_common_buffer, 0, sizeof(fsp_rt_common_buffer));
	if (s3wake) {
	fsp_rt_common_buffer.BootMode = BOOT_ON_S3_RESUME;
	} else if (params->saved_data != NULL) {
	fsp_rt_common_buffer.BootMode =
	BOOT_ASSUMING_NO_CONFIGURATION_CHANGES;
	} else {
	fsp_rt_common_buffer.BootMode = BOOT_WITH_FULL_CONFIGURATION;
	}
	fsp_rt_common_buffer.UpdDataRgnPtr = &memory_init_params;
	fsp_rt_common_buffer.BootLoaderTolumSize = cbmem_overhead_size();

	/* Get any board specific changes */
	fsp_memory_init_params.NvsBufferPtr = (void *)params->saved_data;
	fsp_memory_init_params.RtBufferPtr = &fsp_rt_common_buffer;
	fsp_memory_init_params.HobListPtr = &hob_list_ptr;

	/* Update the UPD data */
	soc_memory_init_params(params, &memory_init_params);
	mainboard_memory_init_params(params, &memory_init_params);

	if (CONFIG(MMA))
	setup_mma(&memory_init_params);

	post_code(POST_MEM_PREINIT_PREP_END);

	/* Display the UPD data */
	if (CONFIG(DISPLAY_UPD_DATA))
	soc_display_memory_init_params(original_params,
	&memory_init_params);

	/* Call FspMemoryInit to initialize RAM */
	fsp_memory_init = (FSP_MEMORY_INIT)(fsp_header->ImageBase
	+ fsp_header->FspMemoryInitEntryOffset);
	printk(BIOS_DEBUG, "Calling FspMemoryInit: %p\n", fsp_memory_init);
	printk(BIOS_SPEW, " %p: NvsBufferPtr\n",
	fsp_memory_init_params.NvsBufferPtr);
	printk(BIOS_SPEW, " %p: RtBufferPtr\n",
	fsp_memory_init_params.RtBufferPtr);
	printk(BIOS_SPEW, " %p: HobListPtr\n",
	fsp_memory_init_params.HobListPtr);

	timestamp_add_now(TS_FSP_MEMORY_INIT_START);
	post_code(POST_FSP_MEMORY_INIT);
	status = fsp_memory_init(&fsp_memory_init_params);
	mainboard_after_memory_init();
	post_code(0x37);
	timestamp_add_now(TS_FSP_MEMORY_INIT_END);

	printk(BIOS_DEBUG, "FspMemoryInit returned 0x%08x\n", status);
	if (status != EFI_SUCCESS)
	die_with_post_code(POST_RAM_FAILURE,
	"ERROR - FspMemoryInit failed to initialize memory!\n");

	/* Locate the FSP reserved memory area */
	fsp_reserved_bytes = 0;
	fsp_memory = get_next_resource_hob(&fsp_reserved_guid, hob_list_ptr);
	if (fsp_memory == NULL) {
	fsp_verification_failure = 1;
	printk(BIOS_ERR,
	"7.2: FSP_RESERVED_MEMORY_RESOURCE_HOB missing!\n");
	} else {
	fsp_reserved_bytes = fsp_memory->ResourceLength;
	printk(BIOS_DEBUG, "Reserving 0x%016lx bytes for FSP\n",
	(unsigned long int)fsp_reserved_bytes);
	}

	/* Display SMM area */
	if (CONFIG(HAVE_SMI_HANDLER)) {
	smm_region(&smm_base, &smm_size);
	printk(BIOS_DEBUG, "0x%08x: smm_size\n", (unsigned int)smm_size);
	printk(BIOS_DEBUG, "0x%08x: smm_base\n", (unsigned int)smm_base);
	}

	/* Migrate CAR data */
	printk(BIOS_DEBUG, "%p: cbmem_top\n", cbmem_top());
	if (!s3wake) {
	cbmem_initialize_empty_id_size(CBMEM_ID_FSP_RESERVED_MEMORY,
	fsp_reserved_bytes);
	} else if (cbmem_initialize_id_size(CBMEM_ID_FSP_RESERVED_MEMORY,
	fsp_reserved_bytes)) {
	printk(BIOS_DEBUG, "Failed to recover CBMEM in S3 resume.\n");
	/* Failed S3 resume, reset to come up cleanly */
	/* FIXME: A "system" reset is likely enough: */
	full_reset();
	}

	/* Save the FSP runtime parameters. */
	fsp_set_runtime(fsp_header, hob_list_ptr);

	/* Lookup the FSP_BOOTLOADER_TOLUM_HOB */
	cbmem_root = get_next_resource_hob(&bootldr_tolum_guid, hob_list_ptr);
	if (cbmem_root == NULL) {
	fsp_verification_failure = 1;
	printk(BIOS_ERR, "7.4: FSP_BOOTLOADER_TOLUM_HOB missing!\n");
	printk(BIOS_ERR, "BootLoaderTolumSize: 0x%08x bytes\n",
	fsp_rt_common_buffer.BootLoaderTolumSize);
	}

	/* Locate the FSP_SMBIOS_MEMORY_INFO HOB */
	memory_info_hob = get_next_guid_hob(&memory_info_hob_guid,
	hob_list_ptr);
	if (memory_info_hob == NULL) {
	printk(BIOS_ERR, "FSP_SMBIOS_MEMORY_INFO HOB missing!\n");
	fsp_verification_failure = 1;
	}

	if (hob_list_ptr == NULL)
	die_with_post_code(POST_RAM_FAILURE,
	"ERROR - HOB pointer is NULL!\n");

	/*
	* Verify that FSP is generating the required HOBs:
	* 7.1: FSP_BOOTLOADER_TEMP_MEMORY_HOB only produced for FSP 1.0
	* 7.2: FSP_RESERVED_MEMORY_RESOURCE_HOB verified above
	* 7.3: FSP_NON_VOLATILE_STORAGE_HOB only produced when
	* new NVS data is generated, verified below
	* 7.4: FSP_BOOTLOADER_TOLUM_HOB verified above
	* 7.5: EFI_PEI_GRAPHICS_INFO_HOB produced by SiliconInit
	* FSP_SMBIOS_MEMORY_INFO HOB verified above
	*/
	hob_ptr.Raw = get_next_guid_hob(&mrc_guid, hob_list_ptr);
	if ((hob_ptr.Raw == NULL) && (params->saved_data == NULL)) {
	printk(BIOS_ERR, "7.3: FSP_NON_VOLATILE_STORAGE_HOB missing!\n");
	fsp_verification_failure = 1;
	}

	/* Verify all the HOBs are present */
	if (fsp_verification_failure)
	printk(BIOS_ERR,
	"ERROR - Missing one or more required FSP HOBs!\n");

	/* Display the HOBs */
	if (CONFIG(DISPLAY_HOBS))
	print_hob_type_structure(0, hob_list_ptr);

	/* Get the address of the CBMEM region for the FSP reserved memory */
	fsp_reserved_memory_area = cbmem_find(CBMEM_ID_FSP_RESERVED_MEMORY);
	printk(BIOS_DEBUG, "%p: fsp_reserved_memory_area\n",
	fsp_reserved_memory_area);

	/* Verify the order of CBMEM root and FSP memory */
	if ((fsp_memory != NULL) && (cbmem_root != NULL) &&
	(cbmem_root->PhysicalStart <= fsp_memory->PhysicalStart)) {
	fsp_verification_failure = 1;
	printk(BIOS_ERR,
	"ERROR - FSP reserved memory above CBMEM root!\n");
	}

	/* Verify that the FSP memory was properly reserved */
	if ((fsp_memory != NULL) && ((fsp_reserved_memory_area == NULL) \|\|
	(fsp_memory->PhysicalStart !=
	(unsigned int)fsp_reserved_memory_area))) {
	fsp_verification_failure = 1;
	printk(BIOS_ERR, "ERROR - Reserving FSP memory area!\n");

	if (CONFIG(HAVE_SMI_HANDLER) && cbmem_root != NULL) {
	size_t delta_bytes = smm_base
	- cbmem_root->PhysicalStart
	- cbmem_root->ResourceLength;
	printk(BIOS_ERR,
	"0x%08x: Chipset reserved bytes reported by FSP\n",
	(unsigned int)delta_bytes);
	die_with_post_code(POST_INVALID_VENDOR_BINARY,
	"Please verify the chipset reserved size\n");
	}
	}

	/* Verify the FSP 1.1 HOB interface */
	if (fsp_verification_failure)
	die_with_post_code(POST_INVALID_VENDOR_BINARY,
	"ERROR - coreboot's requirements not met by FSP binary!\n");

	/* Locate the memory configuration data to speed up the next reboot */
	mrc_hob = get_next_guid_hob(&mrc_guid, hob_list_ptr);
	if (mrc_hob == NULL) {
	printk(BIOS_DEBUG,
	"Memory Configuration Data Hob not present\n");
	} else {
	params->data_to_save = GET_GUID_HOB_DATA(mrc_hob);
	params->data_to_save_size = ALIGN_UP(
	((u32)GET_HOB_LENGTH(mrc_hob)), 16);
	}
	}

	/* Initialize the UPD parameters for MemoryInit */
	__weak void mainboard_memory_init_params(
	struct romstage_params *params,
	MEMORY_INIT_UPD *upd_ptr)
	{
	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
	}

	/* Display the UPD parameters for MemoryInit */
	__weak void soc_display_memory_init_params(
	const MEMORY_INIT_UPD old, MEMORY_INIT_UPD new)
	{
	printk(BIOS_SPEW, "UPD values for MemoryInit:\n");
	hexdump32(BIOS_SPEW, new, sizeof(*new));
	}

	/* Initialize the UPD parameters for MemoryInit */
	__weak void soc_memory_init_params(
	struct romstage_params *params,
	MEMORY_INIT_UPD *upd)
	{
	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
	}

	/* Initialize the SoC after MemoryInit */
	__weak void mainboard_after_memory_init(void)
	{
	printk(BIOS_DEBUG, "WEAK: %s/%s called\n", __FILE__, __func__);
	}