Reks: mark GpioInt() resources as PullDefault
Coreboot considers GPIO resources first-class citizens and initializes
all pads according to their intended use, with necessary pull settings
applied. Therefore let's use PullDefault as pull qualifier in AML,
letting the kernel know that it shoudl not attempt to alter pull settings
when using GPIOs.
BUG=None
TEST=Built and booted on Reks
Change-Id: Iff58a324e73a7eeac9b38df05a095fcfe7acd31b
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/905455
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
diff --git a/src/mainboard/google/reks/acpi/mainboard.asl b/src/mainboard/google/reks/acpi/mainboard.asl
index fea5bdd..c9cb95e 100644
--- a/src/mainboard/google/reks/acpi/mainboard.asl
+++ b/src/mainboard/google/reks/acpi/mainboard.asl
@@ -68,7 +68,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.I2C1", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
})
Return (BUF0)
@@ -107,7 +107,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.I2C1", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TOUCH_GPIO_INDEX }
})
Return (BUF0)
@@ -154,7 +154,7 @@
)
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
} )
Return (SBUF)
@@ -185,7 +185,7 @@
AddressingMode7Bit, /* AddressingMode */
"\\_SB.I2C6", /* ResourceSource */
)
- GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Level, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
})
@@ -209,7 +209,7 @@
Name (GBUF, ResourceTemplate ()
{
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
})
}
@@ -220,7 +220,7 @@
{
Name (RBUF, ResourceTemplate ()
{
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_SCI_GPIO_INDEX }
})
Return (RBUF)
diff --git a/src/mainboard/google/reks/acpi/superio.asl b/src/mainboard/google/reks/acpi/superio.asl
index 52d1be6..cf7dd80 100644
--- a/src/mainboard/google/reks/acpi/superio.asl
+++ b/src/mainboard/google/reks/acpi/superio.asl
@@ -27,7 +27,7 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
/* Override default IRQ settings */
-#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\
+#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,\
"\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX }
/* ACPI code for EC SuperIO functions */
