Celes: mark GpioInt() resources as PullDefault
Coreboot considers GPIO resources first-class citizens and initializes
all pads according to their intended use, with necessary pull settings
applied. Therefore let's use PullDefault as pull qualifier in AML,
letting the kernel know that it shoudl not attempt to alter pull settings
when using GPIOs.
BUG=None
TEST=Built and booted on Celes
Change-Id: Iff58a324e73a7eeac9b38df05a095fcfe7acd31b
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/902897
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
diff --git a/src/mainboard/google/celes/acpi/mainboard.asl b/src/mainboard/google/celes/acpi/mainboard.asl
index 59261b2..12b60a3 100644
--- a/src/mainboard/google/celes/acpi/mainboard.asl
+++ b/src/mainboard/google/celes/acpi/mainboard.asl
@@ -74,7 +74,7 @@
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
} )
Return (SBUF)
@@ -108,7 +108,7 @@
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C6", // ResourceSource
)
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
})
@@ -142,7 +142,7 @@
AddressingMode7Bit, // AddressingMode
"\\_SB.I2C6", // ResourceSource
)
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_TRACKPAD_GPIO_INDEX }
})
@@ -165,7 +165,7 @@
Name (GBUF, ResourceTemplate ()
{
/* Jack Detect (index 0) */
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }
})
}
@@ -176,7 +176,7 @@
{
Name (RBUF, ResourceTemplate ()
{
- GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,
+ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,
"\\_SB.GPNC") { BOARD_SCI_GPIO_INDEX }
})
Return (RBUF)
diff --git a/src/mainboard/google/celes/acpi/superio.asl b/src/mainboard/google/celes/acpi/superio.asl
index bda2452..784014a 100644
--- a/src/mainboard/google/celes/acpi/superio.asl
+++ b/src/mainboard/google/celes/acpi/superio.asl
@@ -27,7 +27,7 @@
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
/* Override default IRQ settings */
-#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,\
+#define SIO_EC_PS2K_IRQ GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullDefault,,\
"\\_SB.GPNC") { BOARD_I8042_GPIO_INDEX }
/* ACPI code for EC SuperIO functions */
