HACK!!! psp: Remove BootDone command
The common PSP code automatically sends the command, however FSP also
happens to send it in response to a Notify. The 2nd instance of the
command generates a timeout error.
Change-Id: I819ab0b80d2a3cf6cd24f3e7170cae779dcc7cef
Signed-off-by: Marshall Dawson <marshall.dawson@amd.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/2020369
Commit-Queue: Eric Peers <epeers@google.com>
Tested-by: Eric Peers <epeers@google.com>
Reviewed-by: Eric Peers <epeers@google.com>
diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c
index 89973ae..d3e0ab5 100644
--- a/src/soc/amd/common/block/psp/psp.c
+++ b/src/soc/amd/common/block/psp/psp.c
@@ -181,27 +181,27 @@
return cmd_status;
}
-/*
- * Notify the PSP that the system is completing the boot process. Upon
- * receiving this command, the PSP will only honor commands where the buffer
- * is in SMM space.
- */
-static void psp_notify_boot_done(void *unused)
-{
- int cmd_status;
- struct mbox_default_buffer buffer = {
- .header = {
- .size = sizeof(buffer)
- }
- };
-
- printk(BIOS_DEBUG, "PSP: Notify that POST is finishing... ");
-
- cmd_status = send_psp_command(MBOX_BIOS_CMD_BOOT_DONE, &buffer);
-
- /* buffer's status shouldn't change but report it if it does */
- print_cmd_status(cmd_status, &buffer);
-}
+///*
+// * Notify the PSP that the system is completing the boot process. Upon
+// * receiving this command, the PSP will only honor commands where the buffer
+// * is in SMM space.
+// */
+//static void psp_notify_boot_done(void *unused)
+//{
+// int cmd_status;
+// struct mbox_default_buffer buffer = {
+// .header = {
+// .size = sizeof(buffer)
+// }
+// };
+//
+// printk(BIOS_DEBUG, "PSP: Notify that POST is finishing... ");
+//
+// cmd_status = send_psp_command(MBOX_BIOS_CMD_BOOT_DONE, &buffer);
+//
+// /* buffer's status shouldn't change but report it if it does */
+// print_cmd_status(cmd_status, &buffer);
+//}
/* Notify PSP the system is going to a sleep state. */
void psp_notify_sx_info(u8 sleep_type)
@@ -278,5 +278,5 @@
return cmd_status;
}
-BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_BOOT, BS_ON_ENTRY,
- psp_notify_boot_done, NULL);
+//BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_BOOT, BS_ON_ENTRY,
+// psp_notify_boot_done, NULL);
