commit f5a459c13d804c6a992f928da4274e7a39b4deef
author Allen Li <ayatane@chromium.org> Fri Aug 24 12:27:14 2018 -0700
committer Allen Li <ayatane@chromium.org> Fri Aug 24 19:31:12 2018 +0000
tree de081dfb32041797bee60b941d31e845aef1c8f8
parent 83cdcd95004eb5c7cf8562a497c70be80d928877

autotest: Close all non standard fds for Lucifer

Lucifer interprets fd 3 as LogDog output.

BUG=chromium:877544
TEST=None

Change-Id: I4ac64a080be05311b4a97e747f9b392d7b1ca5f7
Reviewed-on: https://chromium-review.googlesource.com/1188803
Reviewed-by: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>

venv/lucifer/eventlib.py

diff --git a/venv/lucifer/eventlib.py b/venv/lucifer/eventlib.py
index 21844a7..cd13355 100644
--- a/venv/lucifer/eventlib.py
+++ b/venv/lucifer/eventlib.py
@@ -88,7 +88,7 @@
     @param returns: exit status of command.
     """
     logger.debug('Starting event command with %r', args)
-    with subprocess32.Popen(args, stdout=PIPE) as proc:
+    with subprocess32.Popen(args, stdout=PIPE, close_fds=True) as proc:
         logger.debug('Event command child pid is %d', proc.pid)
         _handle_subprocess_events(event_handler, proc)
     logger.debug('Event command child with pid %d exited with %d',