config_unittest: Remove integration test
The removed test checks whether each JSON file in fw-testing-configs.py
has a correct-looking "platform" attribute. This is not a unit-test; it
is an integration test. It is redundant; we test that same information
in the fw-testing-configs repo. It has caused a CQ failure before in
Autotest. Let's remove that test from Tauto.
BUG=b:171419697
TEST=config_unittest.py
Change-Id: I4e07368eeac723aff79065551bbb53bc30b21a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2577866
Tested-by: Greg Edelston <gredelston@google.com>
Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Greg Edelston <gredelston@google.com>
diff --git a/server/cros/faft/utils/config_unittest.py b/server/cros/faft/utils/config_unittest.py
index ba35c6e..b9ef034 100755
--- a/server/cros/faft/utils/config_unittest.py
+++ b/server/cros/faft/utils/config_unittest.py
@@ -174,30 +174,6 @@
self.assertEqual(parent_modelB_config.attr2, 'parent_attr2')
-class PlatformNamesTestCase(unittest.TestCase):
- """Ensure that each config has a correct 'platform' attribute"""
-
- def runTest(self):
- """
- For each platform JSON config file, verify that there is an
- attribute 'platform' whose value exactly matches the file's basename.
- For example, rambi.json should contain {'platform': 'rambi'}
- """
- for filename in os.listdir(config._CONFIG_DIR):
- filepath = os.path.join(config._CONFIG_DIR, filename)
- platform_name, ext = os.path.splitext(filename)
- if ext != '.json' or platform_name in ('DEFAULTS', 'CONSOLIDATED'):
- continue
- with open(filepath) as f:
- d = json.load(f)
- self.assertIn('platform', d,
- msg='JSON file %s did not contain platform attribute' \
- % filepath)
- self.assertEqual(platform_name, d['platform'],
- msg='JSON file %s contained mismatched platform %s' \
- % (filepath, d['platform']))
-
-
class DirectSelfInheritanceTestCase(_MockConfigTestCaseBaseClass):
"""Ensure that a config which inherits from itself raises an error."""
