commit dd67bebb78d9b00e6b14106fef9fa711b97044cd
author Jiaxi Luo <jiaxiluo@chromium.org> Fri Jul 18 16:28:31 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Jul 22 04:12:28 2014 +0000
tree a7c10e72502365e72982b913d08a44f9042432bc
parent dc6e31a09ca866b75bd06caa6323828b6f6ec5f0

[autotest] Enforce control file when creating a "standard" test.

Control file will only be enforced on creating non-suite
and non-parameterized jobs.

BUG=chromium:394989
TEST=ran afe
DEPLOY=apache

Change-Id: I6e263c5de77be832db13a5032312a9f4204af391
Reviewed-on: https://chromium-review.googlesource.com/209161
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>

frontend/afe/rpc_interface.py

diff --git a/frontend/afe/rpc_interface.py b/frontend/afe/rpc_interface.py
index b2bb62f..3d7cade 100644
--- a/frontend/afe/rpc_interface.py
+++ b/frontend/afe/rpc_interface.py
@@ -516,6 +516,9 @@
     @returns The created Job id number.
     """
     control_file = rpc_utils.encode_ascii(control_file)
+    if not control_file:
+        raise model_logic.ValidationError({
+                'control_file' : "Control file cannot be empty"})
 
     if image and hostless:
         return site_rpc_interface.create_suite_job(