commit d6321a1ffa38e4f89d3dd2524b4c80fa3ab80864
author Aviv Keshet <akeshet@chromium.org> Tue Jul 30 18:31:31 2019 -0700
committer Aviv Keshet <akeshet@chromium.org> Wed Jul 31 18:48:51 2019 +0000
tree 54b27f694686dc1579828c865b5278765932fcfe
parent f421891ca0ad057ef8022266b83fedd72cbe806e

autotest: suite runner: fix skylab create-test usage for dimensions

BUG=chromium:988537
TEST=None

Change-Id: I5629c5e93bdc4c8468cb246bd25e96e946b31cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1727582
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org>

venv/skylab_suite/suite_utils.py

diff --git a/venv/skylab_suite/suite_utils.py b/venv/skylab_suite/suite_utils.py
index 8de8ea1..cf47e0f 100644
--- a/venv/skylab_suite/suite_utils.py
+++ b/venv/skylab_suite/suite_utils.py
@@ -115,12 +115,13 @@
     dimensions = _compute_dimensions(test_spec.test.dependencies)
     keyvals_flat = _compute_job_keyvals_flat(test_spec.keyvals, suite_id)
 
+    for dim in dimensions:
+        cmd += ['-dim', dim]
     for tag in tags:
         cmd += ['-tag', tag]
     for keyval in keyvals_flat:
         cmd += ['-keyval', keyval]
     cmd += [test_spec.test.name]
-    cmd += dimensions
 
     if dry_run:
         logging.info('Would have created task with command %s', cmd)