commit c433ddd239a8f056c25150f2f51be2795c3fda32
author Dossym Nurmukhanov <dossym@google.com> Mon Dec 28 16:15:08 2020 -0800
committer Commit Bot <commit-bot@chromium.org> Tue Dec 29 14:32:42 2020 +0000
tree 04441cfc3780096a21cf3d429be62b9eaf574614
parent 76a38ef0cf5a46a85769b7b87756743cf712270f

FAFT: Fix flashrom utility script to use proper args

The image argument used to be ignored when enabling WP regions.
With the later flashrom update, this argument is now validated and
the command fails.

BUG=b:175614843
TEST=Ran firmware_WriteProtectFunc FAFT test

Change-Id: I08bf55f7645712d36336f9745fc2cb66e0b7bec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2605628
Tested-by: Dossym Nurmukhanov <dossym@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Commit-Queue: Dossym Nurmukhanov <dossym@chromium.org>

client/cros/faft/utils/saft_flashrom_util.py

diff --git a/client/cros/faft/utils/saft_flashrom_util.py b/client/cros/faft/utils/saft_flashrom_util.py
index 0475b54..8570bff 100644
--- a/client/cros/faft/utils/saft_flashrom_util.py
+++ b/client/cros/faft/utils/saft_flashrom_util.py
@@ -317,8 +317,8 @@
         @param region: Region to set (usually WP_RO)
         @param enabled: if True, run --wp-enable; if False, run --wp-disable.
         """
-        cmd = 'flashrom %s --verbose --image %s --wp-region %s' % (
-                self._target_command, image_file, region)
+        cmd = 'flashrom %s --verbose --image %s:%s --wp-region %s' % (
+                self._target_command, region, image_file, region)
         if enabled is not None:
             cmd += ' '
             cmd += '--wp-enable' if enabled else '--wp-disable'