commit 3936af55543722cd83f4b0de52e642578a3fb648
author Steve Fung <stevefung@chromium.org> Wed Oct 08 00:50:01 2014 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Wed Jan 14 17:18:10 2015 +0000
tree 0851e79deb6716b362c0c28fb2f75b3f225850c7
parent 785887ce12488b242ca96e779b8f2dc8ba016476

power: Use --flag=value for arguments to backlight_tool

With the switch to using chromeos::FlagHelper and base::CommandLine,
setting flags using "--flag value" for powerd tools is no longer
supported.

BUG=chromium:421244
TEST=`test_that -b daisy :lab: e:power_.*`

Change-Id: I2cd9e0b6257ddae90431c0a9b78f9794771caa6e
Reviewed-on: https://chromium-review.googlesource.com/222065
Tested-by: Steve Fung <stevefung@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Ullysses A Eoff <ullysses.a.eoff@intel.com>
Commit-Queue: Ullysses A Eoff <ullysses.a.eoff@intel.com>
(cherry picked from commit 9297d9005cf6e3ffc7a3158cacf67e9856c142fc)
Reviewed-on: https://chromium-review.googlesource.com/240574
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

client/cros/power_utils.py

diff --git a/client/cros/power_utils.py b/client/cros/power_utils.py
index e43ea82..c8b4635 100644
--- a/client/cros/power_utils.py
+++ b/client/cros/power_utils.py
@@ -156,7 +156,7 @@
         Args:
           level: integer of brightness to set
         """
-        self._try_bl_cmd('--set_brightness %d' % (level))
+        self._try_bl_cmd('--set_brightness=%d' % (level))
 
 
     def set_percent(self, percent):
@@ -165,7 +165,7 @@
         Args:
           percent: float between 0 and 100
         """
-        self._try_bl_cmd('--set_brightness_percent %f' % (percent))
+        self._try_bl_cmd('--set_brightness_percent=%f' % (percent))
 
 
     def set_resume_level(self, level):
@@ -174,7 +174,7 @@
         Args:
           level: integer of brightness to set
         """
-        self._try_bl_cmd('--set_resume_brightness %d' % (level))
+        self._try_bl_cmd('--set_resume_brightness=%d' % (level))
 
 
     def set_resume_percent(self, percent):
@@ -183,7 +183,7 @@
         Args:
           percent: float between 0 and 100
         """
-        self._try_bl_cmd('--set_resume_brightness_percent %f' % (percent))
+        self._try_bl_cmd('--set_resume_brightness_percent=%f' % (percent))
 
 
     def set_default(self):

client/cros/sys_power.py

diff --git a/client/cros/sys_power.py b/client/cros/sys_power.py
index 792d2e0..2154f69 100644
--- a/client/cros/sys_power.py
+++ b/client/cros/sys_power.py
@@ -101,8 +101,8 @@
     """
     alarm, wakeup_count = prepare_wakeup(suspend_seconds)
     upstart.ensure_running(['powerd'])
-    command = ('/usr/bin/powerd_dbus_suspend --delay %d --timeout 30 '
-               '--wakeup_count %d') % (delay_seconds, wakeup_count)
+    command = ('/usr/bin/powerd_dbus_suspend --delay=%d --timeout=30 '
+               '--wakeup_count=%d') % (delay_seconds, wakeup_count)
     logging.info("Running '%s'", command)
     os.system(command)
     check_wakeup(alarm)
@@ -178,8 +178,8 @@
     # since we cannot have utils.system_output in here, we need a workaround
     output = '/tmp/memory_suspend_output'
     alarm, wakeup_count = prepare_wakeup(seconds)
-    status = os.system('/usr/bin/memory_suspend_test --wakeup_count %d '
-                       '--size %d > %s' % (wakeup_count, size, output))
+    status = os.system('/usr/bin/memory_suspend_test --wakeup_count=%d '
+                       '--size=%d > %s' % (wakeup_count, size, output))
     status = os.WEXITSTATUS(status)
     if status == 2:
         logging.error('memory_suspend_test found the following errors:')