touch_UpdateErrors: use `--text` with `grep`
This reveals a problem with `touch_UpdateErrors.stylus` on Eve, which
passes whenever it sees a log message containing the updater name and
"wacom" (where it should check for the `hw_id`), for which I've filed
b/175159101. This fixes `touch_UpdateErrors.touchscreen`, though.
BUG=b:172622505,b:175159101
TEST=run `touch_UpdateErrors.stylus` test on Eve
Change-Id: Ifa261a5157610a87e4d1ac24334405ca744c17c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2580130
Tested-by: Harry Cutts <hcutts@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
diff --git a/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py b/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py
index 06bcc63..057ac72 100644
--- a/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py
+++ b/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py
@@ -92,7 +92,10 @@
updater_name = 'touch-firmware-update'
start_line = self._find_logs_start_line()
- log_cmd = 'tail -n +%s /var/log/messages | grep -i %s' % (
+ # Null characters sometimes slip into /var/log/messages, causing grep to
+ # treat it as a binary file (and output "binary file matches" rather
+ # than the matching text). --text forces grep to treat it as text file.
+ log_cmd = 'tail -n +%s /var/log/messages | grep --text -i %s' % (
start_line, updater_name)
pass_terms = ['%s.*%s' % (updater_name, hw_id) ]
