pre-upload: require use-manifests=strict for new repos
We don't want people to add new repos w/out manifests, so make it a
presubmit failure.
BUG=chromium:207003
TEST=unittests pass
Change-Id: Id241b0faad7a569dfeb471119952c770e2058021
Reviewed-on: https://chromium-review.googlesource.com/312390
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
diff --git a/pre-upload.py b/pre-upload.py
index 74ae0fa..0fe499d 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -1070,9 +1070,8 @@
errors += ['enable %s with: %s' % (reason, line)]
# Require one of these settings.
- if ('use-manifests = true' not in data and
- 'use-manifests = strict' not in data):
- errors += ['enable file checking with: use-manifests = true']
+ if 'use-manifests = strict' not in data:
+ errors += ['enable file checking with: use-manifests = strict']
# Require repo-name to be set.
for line in data:
diff --git a/pre-upload_unittest.py b/pre-upload_unittest.py
index d11ee3e..d4f458d 100755
--- a/pre-upload_unittest.py
+++ b/pre-upload_unittest.py
@@ -600,7 +600,7 @@
'profile_eapi_when_unspecified = 5-progress',
'repo-name = link',
'thin-manifests = true',
- 'use-manifests = true',
+ 'use-manifests = strict',
]
lines = []