commit 49ec7e9cd94859eb2f5c86d2c341b4b86f338325
author Steve Fung <stevefung@chromium.org> Mon Mar 23 16:07:12 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Tue Mar 24 07:17:47 2015 +0000
tree d528def389b39e81a0939cf427af93050e2b564c
parent 3554bc95db1401f8cf0e94a9991700d28b4b1f2f

pre-upload: Move manifest check into individual repos

We're moving the hardcoded check lists out of the pre-upload script.

CQ-DEPEND=CL:260751, CL:260712, CL:260733, CL:260732
CQ-DEPEND=CL:*209166, CL:*209167
BUG=chromium:466264
TEST=Uploading a CL with a bad manifest is rejected.

Change-Id: Id21d4479435e7e5e50a756f19cff1f2fe5bc72c8
Reviewed-on: https://chromium-review.googlesource.com/262042
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Trybot-Ready: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index f11d0d8..7178a05 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -1125,16 +1125,11 @@
 # dict[project] = [callback1, callback2]
 _PROJECT_SPECIFIC_HOOKS = {
     "chromeos/autotest-tools": [_run_json_check],
-    "chromeos/overlays/chromeos-overlay": [_check_manifests],
-    "chromeos/overlays/chromeos-partner-overlay": [_check_manifests],
     "chromeos/platform/ec-private": [_run_checkpatch_ec,
                                      _check_change_has_branch_field],
     "chromeos/third_party/intel-framework": [_check_change_has_branch_field],
     "chromeos/vendor/kernel-exynos-staging": [_run_checkpatch,
                                               _kernel_configcheck],
-    "chromiumos/overlays/board-overlays": [_check_manifests],
-    "chromiumos/overlays/chromiumos-overlay": [_check_manifests],
-    "chromiumos/overlays/portage-stable": [_check_manifests],
     "chromiumos/platform2": [_check_project_prefix],
     "chromiumos/platform/depthcharge": [_check_change_has_branch_field,
                                         _check_change_has_signoff_field,
@@ -1165,6 +1160,7 @@
     'signoff_check': _check_change_has_signoff_field,
     'bug_field_check': _check_change_has_bug_field,
     'test_field_check': _check_change_has_test_field,
+    'manifest_check': _check_manifests,
 }