commit 4bcd9fa6db7ec490449aed787278366798a5a403
author Vadim Bendebury <vbendeb@chromium.org> Thu Aug 07 12:27:37 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Aug 13 02:51:00 2014 +0000
tree 0e9b30f994d1d70d2da18dc81574cabfe5a2e087
parent 2b62d747d2208044815d02a9cf7ade359129f18b

add checks for depthcharge and coreboot

Vendors start making contributions to Depthcharge, so the
Signed-off-by: clause will be useful.

Coreboot patches were not being checked at all until this change, it
has been decided to follow the kernel style for now, ignoring certain
violations, more exceptions could be added later as required.

BUG=None
TEST=attempts to upload coreboot patch with lines longer than 80
    columns fail now.

Change-Id: I7015be45961212b00facde7e015db02339d5c452
Reviewed-on: https://chromium-review.googlesource.com/211431
Tested-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index b188ada..6f98e5b 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -786,6 +786,13 @@
       'SPACING,PREFER_PACKED,PREFER_PRINTF,PREFER_ALIGNED,GLOBAL_INITIALISERS,'
       'INITIALISED_STATIC,OPEN_BRACE,TRAILING_STATEMENTS'])
 
+def _run_checkpatch_coreboot(project, commit):
+  """Runs checkpatch with options for coreboot."""
+  return _run_checkpatch(project, commit, [
+      '--no-tree',
+      '--ignore=NEW_TYPEDEFS,PREFER_PACKED,PREFER_PRINTF,PREFER_ALIGNED,'
+      'GLOBAL_INITIALISERS,INITIALISED_STATIC'])
+
 
 def _kernel_configcheck(_project, commit):
   """Makes sure kernel config changes are not mixed with code changes"""
@@ -954,12 +961,14 @@
     "chromiumos/overlays/chromiumos-overlay": [_check_manifests],
     "chromiumos/overlays/portage-stable": [_check_manifests],
     "chromiumos/platform2": [_check_project_prefix],
-    "chromiumos/platform/depthcharge": [_run_checkpatch_depthcharge],
+    "chromiumos/platform/depthcharge": [_check_change_has_signoff_field,
+                                        _run_checkpatch_depthcharge],
     "chromiumos/platform/ec": [_run_checkpatch_ec,
                                _check_change_has_branch_field],
     "chromiumos/platform/mosys": [_check_change_has_branch_field],
     "chromiumos/platform/vboot_reference": [_check_change_has_branch_field],
-    "chromiumos/third_party/coreboot": [_check_change_has_signoff_field],
+    "chromiumos/third_party/coreboot": [_check_change_has_signoff_field,
+                                        _run_checkpatch_coreboot],
     "chromiumos/third_party/flashrom": [_check_change_has_branch_field],
     "chromiumos/third_party/kernel": [_run_checkpatch, _kernel_configcheck],
     "chromiumos/third_party/kernel-next": [_run_checkpatch,