commit 6ec83f912aafe07fb4e9371310291d136c02e22b
author Bertrand SIMONNET <bsimonnet@chromium.org> Fri May 30 10:42:34 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Mon Jun 02 22:21:17 2014 +0000
tree aebadceb5323f220d9bd4120c4c73bd857192931
parent 0e8fc7fbb3c40ee3b0c400c2dd2904518954b410

Prevent commits to common-mk

Common-mk has been moved to platform2. src/platform/common-mk should not be used
anymore.

BUG=chromium:363685
TEST=Create a commit to common-mk. repo upload -d . -> presubmit check fails.

CQ-DEPEND=CL:201938

Change-Id: Ice027091b70147505f1aaeb6091a7c82017a08ed
Reviewed-on: https://chromium-review.googlesource.com/202315
Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org>
Commit-Queue: Bertrand Simonnet <bsimonnet@chromium.org>
Tested-by: Bertrand Simonnet <bsimonnet@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index 61e7e7e..1b9a414 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -818,6 +818,12 @@
                         ':\n' + stdout if stdout else ''))
 
 
+def _moved_to_platform2(project, _commit):
+  """Forbids commits to legacy repo in src/platform."""
+  return HookFailure('%s has been moved to platform2. This change should be '
+                     'made there.' % project)
+
+
 # Base
 
 
@@ -854,6 +860,9 @@
     "chromiumos/overlays/board-overlays": [_check_manifests],
     "chromiumos/overlays/chromiumos-overlay": [_check_manifests],
     "chromiumos/overlays/portage-stable": [_check_manifests],
+    # TODO(bsimonnet): remove this check once src/platform/common-mk has been
+    # removed from the manifest (crbug.com/379236).
+    "chromiumos/platform/common-mk": [_moved_to_platform2],
     "chromiumos/platform/ec": [_run_checkpatch_ec,
                                _check_change_has_branch_field],
     "chromiumos/platform/mosys": [_check_change_has_branch_field],
@@ -1188,7 +1197,7 @@
     prog_name = os.path.basename(sys.argv[0])
     try:
       exit_code = direct_main(sys.argv)
-    except BadInvocation, e:
-      print("%s: %s" % (prog_name, str(e)), file=sys.stderr)
+    except BadInvocation, err:
+      print("%s: %s" % (prog_name, str(err)), file=sys.stderr)
       exit_code = 1
   sys.exit(exit_code)