commit 2baad9ed78374718980709d6999aecc2781d3f1f
author Bernie Thompson <bhthompson@google.com> Thu Nov 05 20:46:41 2020 -0800
committer Commit Bot <commit-bot@chromium.org> Fri Nov 06 20:54:15 2020 +0000
tree e75ba26c4dd8bfc6a7e8c8043d5ffa6e5786daba
parent 495976afea9d9c5599d3010839bd21fda2352c7b

Adjust sane blocked term regex

This should also allow for 'insane' so we can reduce double counting.

BUG=chromium:1135047
TEST=./blocked_terms_unittest.py

Change-Id: I1ed27f42136f1d83ecbae9694f8891613d4fe120
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/repohooks/+/2522159
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

blocked_terms.txt

diff --git a/blocked_terms.txt b/blocked_terms.txt
index cf620d0..df0c7e9 100644
--- a/blocked_terms.txt
+++ b/blocked_terms.txt
@@ -13,7 +13,6 @@
 grandfathered
 gr[ae]y.?hat
 gr[ae]y.?list
-insane
 \bhe\b
 \bshe\b
 \bhim\b
@@ -26,7 +25,7 @@
 \bnative
 \bred.?line
 rtfm
-\bsane(\b|\d)
+\b(in)?sane(\b|\d)
 sanity
 slave
 white.?glove

blocked_terms_unittest.py

diff --git a/blocked_terms_unittest.py b/blocked_terms_unittest.py
index c331bec..499e5ba 100755
--- a/blocked_terms_unittest.py
+++ b/blocked_terms_unittest.py
@@ -110,8 +110,10 @@
                     (2, 'blocked (sane)'),
                     (3, 'blocked .sane'),
                     (4, 'blocked SANE'),
-                    (5, 'blocked sane1'),],
-        self.MATCH: 5,
+                    (5, 'blocked sane1'),
+                    (6, 'blocked insane'),
+                    (7, 'blocked .insane'),],
+        self.MATCH: 7,
     }
     self.CheckKeyword(test_instance_blocked)
 

unblocked_terms.txt

diff --git a/unblocked_terms.txt b/unblocked_terms.txt
index 62b0f76..d6c9717 100644
--- a/unblocked_terms.txt
+++ b/unblocked_terms.txt
@@ -24,7 +24,6 @@
 # grandfathered
 # gr[ae]y.?hat
 gr[ae]y.?list
-insane
 \bhe\b
 \bshe\b
 \bhim\b
@@ -37,7 +36,7 @@
 \bnative
 \bred.?line
 rtfm
-\bsane(\b|\d)
+\b(in)?sane(\b|\d)
 sanity
 slave
 # white.?glove