Revert "camera: usb: Remove user space timestamp quirk for external cameras"
This reverts commit 96f499842b709184ea0cfe6a154218bcf2e4af79.
Reason for revert: b/243433282
Original change's description:
> camera: usb: Remove user space timestamp quirk for external cameras
>
> kQuirkUserSpaceTimestamp should not apply to detachable built-in camera
> that is marked as external. For simplicity, remove the quirk for
> external cameras.
>
> BUG=b:237230436
> TEST=Run CTS android.hardware.camera2.cts.CaptureRequestTest#testNoiseReductionModeControlFastFps[1] on banshee.
>
> Change-Id: I4b09f550eb4215548e8c1572e7159766096d08c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3750715
> Reviewed-by: Shik Chen <shik@chromium.org>
> Tested-by: Ren-Pei Zeng <kamesan@chromium.org>
> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org>
Bug: b:237230436, b:243433282
Change-Id: I484e094475409c0c77120fa863520c236ba5a304
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3857502
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org>
Tested-by: Ren-Pei Zeng <kamesan@chromium.org>
diff --git a/camera/hal/usb/camera_hal.cc b/camera/hal/usb/camera_hal.cc
index f54f207..269f1f3 100644
--- a/camera/hal/usb/camera_hal.cc
+++ b/camera/hal/usb/camera_hal.cc
@@ -685,6 +685,10 @@
VLOGF(1) << "Use a new id " << info.camera_id << " for camera "
<< model_id;
}
+
+ // Uses software timestamp from userspace for external cameras, because the
+ // hardware timestamp is not reliable and sometimes even jump backwards.
+ info.quirks |= kQuirkUserSpaceTimestamp;
}
android::CameraMetadata static_metadata, request_template;
