| // Copyright 2019 The Chromium OS Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "arc/network/shill_client.h" |
| |
| #include <memory> |
| #include <set> |
| #include <string> |
| #include <vector> |
| |
| #include <chromeos/dbus/service_constants.h> |
| #include <gmock/gmock.h> |
| #include <gtest/gtest.h> |
| |
| #include "arc/network/fake_shill_client.h" |
| |
| namespace arc_networkd { |
| |
| class ShillClientTest : public testing::Test { |
| protected: |
| void SetUp() override { |
| helper_ = std::make_unique<FakeShillClientHelper>(); |
| client_ = helper_->FakeClient(); |
| client_->RegisterDefaultInterfaceChangedHandler( |
| base::Bind(&ShillClientTest::DefaultInterfaceChangedHandler, |
| base::Unretained(this))); |
| client_->RegisterDevicesChangedHandler(base::Bind( |
| &ShillClientTest::DevicesChangedHandler, base::Unretained(this))); |
| default_ifname_.clear(); |
| devices_.clear(); |
| } |
| |
| void DefaultInterfaceChangedHandler(const std::string& name) { |
| default_ifname_ = name; |
| } |
| |
| void DevicesChangedHandler(const std::set<std::string>& devices) { |
| devices_ = devices; |
| } |
| |
| protected: |
| std::string default_ifname_; |
| std::set<std::string> devices_; |
| std::unique_ptr<FakeShillClient> client_; |
| std::unique_ptr<FakeShillClientHelper> helper_; |
| }; |
| |
| TEST_F(ShillClientTest, DevicesChangedHandlerCalledOnDevicesPropertyChange) { |
| std::vector<dbus::ObjectPath> devices = {dbus::ObjectPath("eth0"), |
| dbus::ObjectPath("wlan0")}; |
| auto value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| EXPECT_EQ(devices.size(), devices_.size()); |
| for (const auto d : devices) { |
| EXPECT_NE(devices_.find(d.value()), devices_.end()); |
| } |
| // Implies the default callback was run; |
| EXPECT_NE(default_ifname_, ""); |
| EXPECT_NE(devices_.find(default_ifname_), devices_.end()); |
| } |
| |
| TEST_F(ShillClientTest, VerifyDevicesPrefixStripped) { |
| std::vector<dbus::ObjectPath> devices = {dbus::ObjectPath("/device/eth0")}; |
| auto value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| EXPECT_EQ(devices_.size(), 1); |
| EXPECT_EQ(*devices_.begin(), "eth0"); |
| // Implies the default callback was run; |
| EXPECT_EQ(default_ifname_, "eth0"); |
| } |
| |
| TEST_F(ShillClientTest, |
| DefaultInterfaceChangedHandlerCalledOnNewDefaultInterface) { |
| client_->SetFakeDefaultInterface("eth0"); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| EXPECT_EQ(default_ifname_, "eth0"); |
| |
| client_->SetFakeDefaultInterface("wlan0"); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| EXPECT_EQ(default_ifname_, "wlan0"); |
| } |
| |
| TEST_F(ShillClientTest, DefaultInterfaceChangedHandlerNotCalledForSameDefault) { |
| client_->SetFakeDefaultInterface("eth0"); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| EXPECT_EQ(default_ifname_, "eth0"); |
| |
| default_ifname_.clear(); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| // Implies the callback was not run the second time. |
| EXPECT_EQ(default_ifname_, ""); |
| } |
| |
| TEST_F(ShillClientTest, DefaultInterfaceFallbackUsingDevices) { |
| // One network device appears. |
| std::vector<dbus::ObjectPath> devices = {dbus::ObjectPath("wlan0")}; |
| auto value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| // That device is used as the fallback default interface. |
| EXPECT_EQ(default_ifname_, "wlan0"); |
| |
| // A second device appears. |
| default_ifname_.clear(); |
| devices = {dbus::ObjectPath("eth0"), dbus::ObjectPath("wlan0")}; |
| value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| // The first device is still used as the fallback, the callback is not run. |
| EXPECT_EQ(default_ifname_, ""); |
| |
| // The second device becomes the default interface. |
| client_->SetFakeDefaultInterface("eth0"); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| // The real default interface is preferred over the fallback interface. |
| EXPECT_EQ(default_ifname_, "eth0"); |
| |
| // The system loses the default interface. |
| client_->SetFakeDefaultInterface(""); |
| client_->NotifyManagerPropertyChange(shill::kDefaultServiceProperty, |
| brillo::Any() /* ignored */); |
| // The fallback interface is used instead. |
| EXPECT_EQ(default_ifname_, "wlan0"); |
| |
| // The first device disappears. |
| devices = {dbus::ObjectPath("eth0")}; |
| value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| // The fallback interface is updated. |
| EXPECT_EQ(default_ifname_, "eth0"); |
| |
| // All devices have disappeared. |
| devices = {}; |
| value = brillo::Any(devices); |
| client_->NotifyManagerPropertyChange(shill::kDevicesProperty, value); |
| // No device is used as the fallback default interface. |
| EXPECT_EQ(default_ifname_, ""); |
| } |
| |
| } // namespace arc_networkd |