commit 59fce788787276b984fbb15d65c7d998b28d524f
author Mike Frysinger <vapier@chromium.org> Fri Jul 31 15:26:29 2020 -0400
committer Mike Frysinger <vapier@chromium.org> Mon Aug 03 00:13:20 2020 +0000
tree bd6d146b35ce52991b77c6a334e4ed110b4042d8
parent b3b6a911670921b029133a19c6dd70f49c1d5c2e

common-mk: check-owners: switch to pathlib

BUG=None
TEST=upload still works

Change-Id: I6154729f4519c4e5650720fe1862dc21d61bd354
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2332952
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

common-mk/check-owners.py

diff --git a/common-mk/check-owners.py b/common-mk/check-owners.py
index 5839740..b610178 100755
--- a/common-mk/check-owners.py
+++ b/common-mk/check-owners.py
@@ -6,15 +6,16 @@
 
 """Linter for various OWNERS files."""
 
+from __future__ import division
 from __future__ import print_function
 
-import os
+from pathlib import Path
 import sys
 
-TOP_DIR = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
+TOP_DIR = Path(__file__).resolve().parent.parent
 
 # Find chromite!
-sys.path.insert(0, os.path.join(TOP_DIR, '..', '..'))
+sys.path.insert(0, str(TOP_DIR.parent.parent))
 
 # pylint: disable=wrong-import-position
 from chromite.lib import commandline
@@ -35,8 +36,8 @@
 
   # ls-tree -z will include a trailing NUL on all entries, not just seperation,
   # so filter it out if found (in case ls-tree behavior changes on us).
-  for path in [x for x in paths if x]:
-    if os.path.isdir(os.path.join(TOP_DIR, path)):
+  for path in [Path(x) for x in paths if x]:
+    if (TOP_DIR / path).is_dir():
       yield path
 
 
@@ -44,8 +45,8 @@
   """Check the subdir OWNERS files exist."""
   ret = 0
   for proj in GetActiveProjects():
-    path = os.path.join(TOP_DIR, proj, 'OWNERS')
-    if not os.path.exists(path):
+    path = TOP_DIR / proj / 'OWNERS'
+    if not path.exists():
       logging.error('*** Project "%s" needs an OWNERS file', proj)
       ret = 1
       continue