commit 097da61406fdf8f7decf0092191db98b9d93a3fe
author Matthew Wang <matthewmwang@chromium.org> Fri Jul 24 14:04:39 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Tue Jul 28 01:04:12 2020 +0000
tree 5522514deb36a78573c84703b618102cbefdaddb
parent 4fa9dbb5fcba73caa2dc3faa0735de8c1aef2bb4

shill: wifi: stop spamming logs with bgscan reconfiguring

Change some LOG()s to SLOG()s to reduce log spam.

BUG=b:161935771
TEST=emerge

Change-Id: I855965e46d0d44582c53bda9c0a5692f86f56a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2318209
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>

shill/wifi/wifi.cc

diff --git a/shill/wifi/wifi.cc b/shill/wifi/wifi.cc
index 07c595e..01060b2 100644
--- a/shill/wifi/wifi.cc
+++ b/shill/wifi/wifi.cc
@@ -614,13 +614,13 @@
     // with pre-set parameters. Otherwise, use extended scan intervals.
     method = kDefaultBgscanMethod;
     if (service->GetEndpointCount() <= 1) {
-      LOG(INFO) << "Background scan intervals extended -- single Endpoint for "
-                << "Service.";
+      SLOG(nullptr, 3) << "Background scan intervals extended -- single "
+                       << "Endpoint for Service.";
       short_interval = kSingleEndpointBgscanShortIntervalSeconds;
       scan_interval = kSingleEndpointBgscanIntervalSeconds;
     }
   } else if (method == WPASupplicant::kNetworkBgscanMethodNone) {
-    LOG(INFO) << "Background scan disabled -- chose None method.";
+    SLOG(nullptr, 3) << "Background scan disabled -- chose None method.";
   } else {
     // If the background scan method was explicitly specified, honor the
     // configured background scan interval.
@@ -631,18 +631,18 @@
     config_string = StringPrintf("%s:%d:%d:%d", method.c_str(), short_interval,
                                  signal_threshold, scan_interval);
   }
-  LOG(INFO) << "Background scan: '" << config_string << "'";
+  SLOG(nullptr, 3) << "Background scan: '" << config_string << "'";
   service_params->Set<string>(WPASupplicant::kNetworkPropertyBgscan,
                               config_string);
   return config_string;
 }
 
 bool WiFi::ReconfigureBgscan(WiFiService* service) {
-  LOG(INFO) << __func__ << " for " << service->log_name();
+  SLOG(this, 3) << __func__ << " for " << service->log_name();
   KeyValueStore bgscan_params;
   string bgscan_string = AppendBgscan(service, &bgscan_params);
   if (service->bgscan_string() == bgscan_string) {
-    LOG(INFO) << "No change in bgscan parameters.";
+    SLOG(this, 3) << "No change in bgscan parameters.";
     return false;
   }
 
@@ -658,6 +658,7 @@
     LOG(ERROR) << "SetProperties for " << id.value() << " failed.";
     return false;
   }
+  LOG(INFO) << "Updated bgscan parameters: " << bgscan_string;
   service->set_bgscan_string(bgscan_string);
   return true;
 }