| commit | 023760eb1d2f84e02ab1423083811793590f22f7 | [log] [tgz] |
|---|---|---|
| author | Yi Chou <yich@google.com> | Wed Dec 09 17:10:52 2020 +0800 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 15 21:33:29 2020 +0000 |
| tree | fff8088cc3d997903f424abc4a04d8526bf42f79 | |
| parent | c76cbfe5a183dbd228bf681e87a27da2bcf47b54 [diff] |
tpm_manager: fix potential bugs in tpm_status
This would fix this error:
/tpm_manager/server/tpm_status_impl.cc:251:9:
The left operand of '&' is a garbage value
if (ERROR_CODE(result) == TPM_E_DISABLED) {
^ ~~~~~~
BUG=b:174652437
TEST=CQ
Change-Id: I3e8519db979fd2316ac1a804039547a2f22c2ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2580972
Tested-by: Yi Chou <yich@google.com>
Reviewed-by: Leo Lai <cylai@google.com>
Commit-Queue: Yi Chou <yich@google.com>
diff --git a/tpm_manager/server/tpm_status_impl.cc b/tpm_manager/server/tpm_status_impl.cc index a592af0..6b7c1fc 100644 --- a/tpm_manager/server/tpm_status_impl.cc +++ b/tpm_manager/server/tpm_status_impl.cc
@@ -271,6 +271,9 @@ CHECK(data); TSS_HTPM tpm_handle = tpm_connection_.GetTpm(); if (tpm_handle == 0) { + if (tpm_result) { + *tpm_result = TSS_E_COMM_FAILURE; + } return false; } uint32_t length = 0;