commit 5657757d1740f4bfc651474ece3e9da1b6c16291
author Simon Glass <sjg@chromium.org> Tue Jul 19 11:08:06 2011 +1200
committer Simon Glass <sjg@chromium.org> Mon Jul 25 19:29:02 2011 -0700
tree 836b3d3d922c7cfe4abd9843710771fefd2b18a9
parent b4447fdd93c630519628793bb9416cd62c8234a4

Implement the --hardware-id option

BUG=chromium-os:17753
TEST=manual: ~/trunk/src/platform/dev/host/cros_bundle_firmware --hardware-id 918273645 -o image
strings image |grep 918273645

Change-Id: I3a1123cad967e471d9e1422dec1a7cbc3aee2b77
Reviewed-on: http://gerrit.chromium.org/gerrit/4345
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Anton Staaf <robotboy@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>

host/cros_bundle_firmware

diff --git a/host/cros_bundle_firmware b/host/cros_bundle_firmware
index 7f7d4be..b2a46da 100755
--- a/host/cros_bundle_firmware
+++ b/host/cros_bundle_firmware
@@ -122,7 +122,7 @@
     bundle.AddConfigList(options.add_config_str)
     bundle.AddConfigList(options.add_config_int, use_int=True)
 
-    out_fname = bundle.Start(options.output)
+    out_fname = bundle.Start(options.hardware_id, options.output)
 
     # Write it to the board if required.
     if options.write:

host/lib/bundle_firmware.py

diff --git a/host/lib/bundle_firmware.py b/host/lib/bundle_firmware.py
index 209d188..24ba2f0 100644
--- a/host/lib/bundle_firmware.py
+++ b/host/lib/bundle_firmware.py
@@ -136,16 +136,21 @@
     if not self.bct_fname:
       self.bct_fname = os.path.join(build_root, 'bct', 'board.bct')
 
-  def _CreateGoogleBinaryBlock(self):
+  def _CreateGoogleBinaryBlock(self, hardware_id):
     """Create a GBB for the image.
 
+    Args:
+      hardware_id: Hardware ID to use for this board. If None, then the
+          default from the Fdt will be used
+
     Returns:
       Path of the created GBB file.
 
     Raises:
       CmdError if a command fails.
     """
-    hwid = self.fdt.GetString('/config/hwid')
+    if not hardware_id:
+      hardware_id = self.fdt.GetString('/config/hwid')
     gbb_size = self.fdt.GetFlashPartSize('ro', 'gbb')
     odir = self._tools.outdir
 
@@ -154,10 +159,11 @@
         self.fdt.GetInt('/lcd/height'))
 
     # This is the magic directory that make_bmp_image writes to!
-    out_dir = 'out_%s' % re.sub(' ', '_', hwid)
+    out_dir = 'out_%s' % re.sub(' ', '_', hardware_id)
     bmp_dir = os.path.join(odir, out_dir)
     self._out.Progress('Creating bitmaps')
-    self._tools.Run('make_bmp_image', [hwid, screen_geometry, 'arm'], cwd=odir)
+    self._tools.Run('make_bmp_image', [hardware_id, screen_geometry, 'arm'],
+        cwd=odir)
 
     self._out.Progress('Creating bitmap block')
     yaml = 'config.yaml'
@@ -172,7 +178,7 @@
     keydir = self._tools.Filename(self._keydir)
     self._tools.Run('gbb_utility', ['-c', ','.join(sizes), gbb], cwd=odir)
     self._tools.Run('gbb_utility', ['-s',
-        '--hwid=%s' % hwid,
+        '--hwid=%s' % hardware_id,
         '--rootkey=%s/root_key.vbpubk' % keydir,
         '--recoverykey=%s/recovery_key.vbpubk' % keydir,
         '--bmpfv=%s' % os.path.join(out_dir, 'bmpblk.bin'),
@@ -263,7 +269,8 @@
     Returns:
       Tuple containing:
         Full path to u-boot.bin.
-        Full path to bootstub.
+        Full path to bootstub (uboot + fdt).
+        Full path to signed blob (uboot + fdt + bct).
 
     Raises:
       CmdError if a command fails.
@@ -340,13 +347,15 @@
     fdt = Fdt(self._tools, self._fdt_fname)
     self.fdt = fdt.Copy(os.path.join(self._tools.outdir, 'updated.dtb'))
 
-  def Start(self, output_fname):
+  def Start(self, hardware_id, output_fname):
     """This creates a firmware bundle according to settings provided.
 
       - Checks options, tools, output directory, fdt.
       - Creates GBB and image.
 
     Args:
+      hardware_id: Hardware ID to use for this board. If None, then the
+          default from the Fdt will be used
       output_fname: Output filename for the image. If this is not None, then
           the final image will be copied here.
 
@@ -355,7 +364,7 @@
     """
     gbb = ''
     if not self._small:
-      gbb = self._CreateGoogleBinaryBlock()
+      gbb = self._CreateGoogleBinaryBlock(hardware_id)
 
     # This creates the actual image.
     uboot, image = self._CreateImage(gbb, self.fdt)