commit ba3029e70c934bd96724f1006816759fe2633b39
author Gilad Arnold <garnold@chromium.org> Fri Mar 08 12:05:59 2013 -0800
committer ChromeBot <chrome-bot@google.com> Fri Mar 15 15:04:31 2013 -0700
tree 6110d2db576f5f8e79380e533270228d59867d63
parent 6de2930aba15a9b5fa891f41ae068bcede389a90

Fix update out-of-bounds check for partition boundary.

This is an off-by-one error caught during the implementation of unit
tests.

BUG=None
TEST=Unit tests (upcoming) pass as expected.

Change-Id: I9a5da10588f0ac4314e9a35280ff1f38c34c88ac
Reviewed-on: https://gerrit.chromium.org/gerrit/44953
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

host/lib/update_payload/checker.py

diff --git a/host/lib/update_payload/checker.py b/host/lib/update_payload/checker.py
index b2920a0..e47456d 100644
--- a/host/lib/update_payload/checker.py
+++ b/host/lib/update_payload/checker.py
@@ -577,7 +577,7 @@
 
       if start_block != common.PSEUDO_EXTENT_MARKER:
         # Check: make sure we're within the partition limit.
-        if part_size and (end_block - 1) * self.block_size > part_size:
+        if part_size and end_block * self.block_size > part_size:
           raise PayloadError(
               '%s: extent (%s) exceeds partition size (%d)' %
               (ex_name, common.FormatExtent(ex, self.block_size), part_size))