commit 9c7f67b47941eddec30bb0da5e6630f6659839e3
author Guenter Roeck <groeck@chromium.org> Tue May 12 12:48:54 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Wed May 13 20:12:16 2020 +0000
tree 2475190a6184624309c0b3ba34a00b20cbf1ecb5
parent 81ed05701bcc90157c91be040276cb79809009da

findmissing: gerrit_interface: Convert to use logging facility

With logging now set up, let's use it.

BUG=None
TEST=Run on GCE or locally

Change-Id: Ia95353f9538874149b484a864e5575d0a75794b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/2197236
Commit-Queue: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>

contrib/findmissing/gerrit_interface.py

diff --git a/contrib/findmissing/gerrit_interface.py b/contrib/findmissing/gerrit_interface.py
index f72dd29..5e5fca6 100755
--- a/contrib/findmissing/gerrit_interface.py
+++ b/contrib/findmissing/gerrit_interface.py
@@ -20,6 +20,7 @@
 """
 
 from __future__ import print_function
+import logging
 import json
 import http
 import os
@@ -45,9 +46,9 @@
             gerrit_credentials_cookies.load()
             return gerrit_credentials_cookies
         except FileNotFoundError:
-            print('Could not locate gitcookies file. Generate cookie file and try again')
-            print('If running locally, ensure gitcookies file is located at ~/.gitcookies')
-            print('Learn more by visiting go/gob-dev#testing-user-authentication')
+            logging.error('Could not locate gitcookies file. Generate cookie file and try again')
+            logging.error('If running locally, ensure gitcookies file is located at ~/.gitcookies')
+            logging.error('Learn more by visiting go/gob-dev#testing-user-authentication')
             raise
 
 
@@ -110,10 +111,10 @@
 
     try:
         set_and_parse_endpoint(abandon_change_endpoint, abandon_payload)
-        print('Abandoned changeid %s on Gerrit' % changeid)
+        logging.info('Abandoned changeid %s on Gerrit', changeid)
     except requests.exceptions.HTTPError as e:
         if e.response.status_code == http.HTTPStatus.CONFLICT:
-            print('Change %s has already been abandoned' % changeid)
+            logging.info('Change %s has already been abandoned', changeid)
         else:
             raise
 
@@ -128,10 +129,10 @@
 
     try:
         set_and_parse_endpoint(restore_change_endpoint, restore_payload)
-        print('Restored changeid %s on Gerrit' % changeid)
+        logging.info('Restored changeid %s on Gerrit', changeid)
     except requests.exceptions.HTTPError as e:
         if e.response.status_code == http.HTTPStatus.CONFLICT:
-            print('Change %s has already been restored' % changeid)
+            logging.info('Change %s has already been restored', changeid)
         else:
             raise
 
@@ -235,7 +236,7 @@
         # There is a Change-Id in the commit log, but Gerrit does not have a
         # matching entry. Fall back to list of e-mails found in tags after
         # the last "cherry picked" message.
-        print('Failed to get reviewer(s) from gerrit for Change-Id %s' % fixee_changeid)
+        logging.warning('Failed to get reviewer(s) from gerrit for Change-Id %s', fixee_changeid)
         emails = git_interface.get_tag_emails_linux_chrome(fixee_kernel_sha)
         if emails:
             reviewers = emails