commit 3a083843fa3523d9fbd179cdeea49aeda180cb4c
author Pi-Hsun Shih <pihsun@chromium.org> Mon Nov 16 18:32:29 2020 +0800
committer Commit Bot <commit-bot@chromium.org> Tue Nov 17 03:02:48 2020 +0000
tree 3ac74ea2ec176bc6b3dfe7388186e7fa1d358f9d
parent 1eb16e4fdc1293ecdbae702fb3c89c817ac33fcf

fromupstream: Don't restrict patchwork ID to be number only.

Some patchwork site use Message ID for the patch_id (for example,
https://patchwork.kernel.org/project/linux-usb/list/), which is
currently unable to be picked by fromupstream.py.

Fix this by using a string instead of int for patch_id.

BUG=None
TEST=With usbpw pointed to
     https://patchwork.kernel.org/project/linux-usb/ in ~/.pwclientrc,
     test that `./fromupstream.py --bug None --test None
     pw://usbpw/1604403610-16577-2-git-send-email-jun.li@nxp.com` works

Change-Id: Ic94c718b0aa86f37a4b7009fc2ddb49a0f61d2c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/2540107
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@chromium.org>
Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org>

contrib/fromupstream.py

diff --git a/contrib/fromupstream.py b/contrib/fromupstream.py
index 55f858d..f8e7bf5 100755
--- a/contrib/fromupstream.py
+++ b/contrib/fromupstream.py
@@ -180,7 +180,7 @@
         args['tag'] = 'FROMLIST: '
 
     try:
-        opener = urllib.request.urlopen('%s/patch/%d/mbox' % (url, patch_id))
+        opener = urllib.request.urlopen('%s/patch/%s/mbox' % (url, patch_id))
     except urllib.error.HTTPError as e:
         errprint('Error: could not download patch: %s' % e)
         sys.exit(1)
@@ -193,7 +193,7 @@
     message_id = mailbox.Message(patch_contents)['Message-Id']
     message_id = re.sub('^<|>$', '', message_id.strip())
     if args['source_line'] is None:
-        args['source_line'] = '(am from %s/patch/%d/)' % (url, patch_id)
+        args['source_line'] = '(am from %s/patch/%s/)' % (url, patch_id)
         for url_template in [
             'https://lore.kernel.org/r/%s',
             # hostap project (and others) are here, but not kernel.org.
@@ -239,10 +239,10 @@
 def _match_patchwork(match, args):
     """Match location: pw://### or pw://PROJECT/###."""
     pw_project = match.group(2)
-    patch_id = int(match.group(3))
+    patch_id = match.group(3)
 
     if args['debug']:
-        print('_match_patchwork: pw_project=%s, patch_id=%d' %
+        print('_match_patchwork: pw_project=%s, patch_id=%s' %
               (pw_project, patch_id))
 
     url = _get_pw_url(pw_project)
@@ -511,7 +511,7 @@
         pprint.pprint(args)
 
     re_matches = (
-        (re.compile(r'^pw://(([^/]+)/)?(\d+)'), _match_patchwork),
+        (re.compile(r'^pw://(([^/]+)/)?(.+)'), _match_patchwork),
         (re.compile(r'^msgid://<?([^>]*)>?'), _match_msgid),
         (re.compile(r'^linux://([0-9a-f]+)'), _match_upstream),
         (re.compile(r'^upstream://([0-9a-f]+)'), _match_upstream),