commit 1853cc21b01eb2324442d275b3ec1ef965746681
author Ken Mixter <kmixter@chromium.org> Sat Nov 19 02:20:27 2011 +0000
committer Gerrit <chrome-bot@google.com> Fri Dec 02 14:53:32 2011 -0800
tree 5338a881bc80d088ceba9174aa0b05836070d86e
parent b28276ad93884ce503fa056ee2f4a1579cdf8149

dev: add --attach to make it unnecessary to look up pids

TEST=used --attach with browser and filename on device and VM

Change-Id: I6ab66825386217b406c340c40010849e80b7e2ab
Reviewed-on: https://gerrit.chromium.org/gerrit/11970
Commit-Ready: Ken Mixter <kmixter@chromium.org>
Tested-by: Ken Mixter <kmixter@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: asharif <asharif@chromium.org>

host/gdb_remote

diff --git a/host/gdb_remote b/host/gdb_remote
index 2e58ffc..833bbf2 100755
--- a/host/gdb_remote
+++ b/host/gdb_remote
@@ -10,6 +10,8 @@
 get_default_board
 
 # Flags
+DEFINE_string attach "" \
+ "pgrep for the given command - 'browser' finds the chrome browser process"
 DEFINE_string board "${DEFAULT_BOARD}" \
  "The board to run debugger on."
 DEFINE_string remote "localhost" \
@@ -94,7 +96,9 @@
 
   if [[ -z "${FLAGS_remote_pid}" ]] ; then
     if [[ -z "${FLAGS_remote_file}" ]] ; then
-      die "--remote_file is required."
+      if [[ -z "${FLAGS_attach}" ]] ; then
+        die "--remote_file is required."
+      fi
     fi
   fi
 
@@ -117,6 +121,27 @@
     die "${FLAGS_remote} is not currently available."
   fi
 
+  if [[ -n "${FLAGS_attach}" ]]; then
+    if [[ "${FLAGS_attach}" == "browser" ]]; then
+      FLAGS_remote_pid=$(run_remote_command \
+        "pstree -p|grep session_manager|cut -d\( -f3 | cut -d\) -f1")
+      if [ -z "${FLAGS_remote_pid}" ]; then
+        die "Unable to find browser process"
+      fi
+    else
+      FLAGS_remote_pid=$(run_remote_command "pgrep -f '${FLAGS_attach}'")
+      local count=$(echo ${FLAGS_remote_pid} | wc -w)
+      if [ ${count} -eq 0 ]; then
+        die "No process matching ${FLAGS_attach}"
+      elif [ ${count} -gt 1 ]; then
+        error "Multiple (${count}) processes matching \"${FLAGS_attach}\":"
+        local pids=$(echo "${FLAGS_remote_pid}" | tr '\n' ' ')
+        run_remote_command "ps ${pids}"
+        exit 1
+      fi
+    fi
+  fi
+
   if [[ ${FLAGS_remote_pid} -ne 0 ]] ; then
     local ssh_cmd="readlink -e /proc/${FLAGS_remote_pid}/exe"
     local err_msg="${FLAGS_remote_pid} is not a valid PID on\
@@ -235,9 +260,12 @@
 
 generate_gdbinit_file
 
+echo "Some helpful GDB commands:"
+echo "directory <path> -- causes path to be searched for source files."
+echo "info functions <regexp> -- find function matching given regexp."
 echo
-echo "To connect to gdbserver, type 'remote_connect' at the gdb prompt."
-echo
+echo "Some helpful gdb_remote specific commands:"
+echo "remote_connect -- reestablish remote connection."
 echo
 
 # Start gdb on local machine.