commit 7c49fda7a8e94706c7f755e0ef1c57b955e76dbb
author Mike Frysinger <vapier@chromium.org> Wed Sep 07 15:47:06 2016 -0400
committer chrome-bot <chrome-bot@chromium.org> Fri Sep 09 14:42:28 2016 -0700
tree 34aa83070c88fd566d487afc0595358cd4ec4d8b
parent d7891ba2b98e0488ed3cbaf59c6e9d3e4dfc534d

cgpt: sanitize features field

Make sure we don't let people add unknown features (like typos).

BUG=chromium:644845
TEST=precq passes

Change-Id: Iebd7ca8719d56c63b5fc301e8c7355b2fc1453c9
Reviewed-on: https://chromium-review.googlesource.com/382811
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

build_library/cgpt.py

diff --git a/build_library/cgpt.py b/build_library/cgpt.py
index 0e6b39f..30f385a 100755
--- a/build_library/cgpt.py
+++ b/build_library/cgpt.py
@@ -329,6 +329,7 @@
       'size', 'fs_size', 'fs_options', 'erase_block_size', 'hybrid_mbr',
       'reserved_erase_blocks', 'max_bad_erase_blocks', 'external_gpt',
       'page_size', 'size_min', 'fs_size_min'))
+  valid_features = set(('expand',))
 
   config = _LoadStackedPartitionConfig(filename)
   try:
@@ -434,6 +435,12 @@
           part['erase_block_size'] = ParseHumanNumber(part['erase_block_size'])
         if 'page_size' in part:
           part['page_size'] = ParseHumanNumber(part['page_size'])
+
+        part.setdefault('features', [])
+        unknown_features = set(part['features']) - valid_features
+        if unknown_features:
+          raise InvalidLayout('%s: Unknown features: %s' %
+                              (part['label'], unknown_features))
   except KeyError as e:
     raise InvalidLayout('Layout is missing required entries: %s' % e)
 
@@ -520,7 +527,7 @@
   for partition in partitions:
     if partition.get('num') == 'metadata':
       continue
-    if 'features' in partition and 'expand' in partition['features']:
+    if 'expand' in partition['features']:
       ret['expand_count'] += 1
       ret['expand_min'] += partition['blocks']
     else:
@@ -760,7 +767,7 @@
                         config['metadata']['block_size'])
 
     if (partition.get('type') != 'blank' and partition['num'] == 1 and
-        'features' in partition and 'expand' in partition['features']):
+        'expand' in partition['features']):
       lines += [
           'local stateful_size=%s' % partition['blocks'],
           'if [ -b $1 ]; then',
@@ -1247,7 +1254,7 @@
         partition.get('type', ''),
         size,
         fs_size,
-        partition.get('features', ''),
+        partition.get('features', []),
     ))
 
 
@@ -1367,7 +1374,7 @@
       raise UnalignedPartition(
           'partition size %s does not divide erase block size %s' %
           (partition['bytes'], erase_block_size))
-    if 'features' in partition and 'expand' in partition['features']:
+    if 'expand' in partition['features']:
       raise ExpandNandImpossible(
           'expand partitions may not be used with raw NAND')