commit 293360dc6f4f38dface8b8b326b2531914db0a27
author Mike Frysinger <vapier@chromium.org> Mon Nov 11 23:15:11 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Sat Nov 16 08:19:39 2019 +0000
tree 7bcf00e27716bc9e989baf04555d88c4245fe91c
parent bebec09ca32f11c8f2d04e5ea0d0f44dfc9f6bf5

drop spammy set -x debug logic

We seem to have a handle on things now, or at the very least, this
spam isn't helping with debugging.  It is making it very hard to
read real build failures on bots & dev systems though.

BUG=chromium:1011891
TEST=CQ passes

Change-Id: Ib221da68c6703f2569b72fed8743740dff8fe253
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/1918107
Reviewed-by: George Engelbrecht <engeg@google.com>
Tested-by: George Engelbrecht <engeg@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

build_library/base_image_util.sh

diff --git a/build_library/base_image_util.sh b/build_library/base_image_util.sh
index 19ff6d9..b3f30eb 100755
--- a/build_library/base_image_util.sh
+++ b/build_library/base_image_util.sh
@@ -178,8 +178,6 @@
   local image_type="usb"
 
   info "Entering create_base_image $*"
-  # TODO(crbug/1011891): remove this
-  set -x
 
   if [[ "${FLAGS_disk_layout}" != "default" ]]; then
     image_type="${FLAGS_disk_layout}"
@@ -512,6 +510,4 @@
     ${SCRIPTS_DIR}/bin/cros_make_image_bootable "${BUILD_DIR}" \
       ${image_name} ${USE_DEV_KEYS} --adjust_part="${FLAGS_adjust_part}"
   fi
-  # TODO(crbug/1011891): remove this.
-  set +x
 }

mount_gpt_image.sh

diff --git a/mount_gpt_image.sh b/mount_gpt_image.sh
index 8875ad8..d5663f4 100755
--- a/mount_gpt_image.sh
+++ b/mount_gpt_image.sh
@@ -9,8 +9,6 @@
 
 # Helper scripts should be run from the same location as this script.
 echo "Entering $0 $*" >&2
-# TODO(crbug/1011891): remove this
-set -x
 
 SCRIPT_ROOT=$(dirname "$(readlink -f "$0")")
 . "${SCRIPT_ROOT}/common.sh" || exit 1