fw_dut_info: Be explicit about newlines.
go vet enforces that the Println argument list does not end with a
newline (background: https://github.com/golang/go/issues/23062), so
migrate to Print, as the two consecutive newlines are intentional for
output formatting.
BUG=b:200825596
TEST=go vet fw_dut_info.go (runs cleanly now)
Change-Id: I133b84d27ba4ef8f9227544200a73844a74c49ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crostestutils/+/3307826
Tested-by: Kevin Shelton <kmshelton@chromium.org>
Auto-Submit: Kevin Shelton <kmshelton@chromium.org>
Commit-Queue: Kevin Shelton <kmshelton@chromium.org>
Reviewed-by: Andrew Luo <aluo@chromium.org>
diff --git a/go/src/firmware/cmd/dut_info/fw_dut_info.go b/go/src/firmware/cmd/dut_info/fw_dut_info.go
index 7436411..b279a0d 100644
--- a/go/src/firmware/cmd/dut_info/fw_dut_info.go
+++ b/go/src/firmware/cmd/dut_info/fw_dut_info.go
@@ -39,21 +39,21 @@
fmt.Println("ChromeOS Version :", d.crOSVersion)
fmt.Println("BIOS Version :", d.biosVersion)
fmt.Println("EC Version :", d.ecROVersion, "/", d.ecRWVersion)
- fmt.Println("cr50 Version :", d.gscVersion, "\n")
+ fmt.Println("cr50 Version :", d.gscVersion)
+ fmt.Println()
fmt.Println("CPU arch :", d.cpuArch)
fmt.Println("CPU speed :", d.cpuSpeed)
fmt.Println("Total Memory :", d.totalMemory)
fmt.Println("Memory Type :", d.memoryType)
if d.mmcModel != "" {
fmt.Println("MMC Model :", d.mmcModel)
- fmt.Println("MMC Firmware :", d.mmcFirmwareVersion, "\n")
+ fmt.Println("MMC Firmware :", d.mmcFirmwareVersion)
} else if d.nvmeModel != "" {
fmt.Println("NVMe Model :", d.nvmeModel)
- fmt.Println("NVMe Firmware :", d.nvmeFirmwareVersion, "\n")
- } else {
- fmt.Println()
+ fmt.Println("NVMe Firmware :", d.nvmeFirmwareVersion)
}
- fmt.Print("VPD info:\n", d.vpd, "\n")
+ fmt.Println()
+ fmt.Println("VPD info:\n", d.vpd)
}
// setModel interfaces with a DUT and sets the model field (the DUT's market identifier).
