commit 3ec12e2373c16d05db0fcc928706017476a3b955
author Grant Grundler <grundler@chromium.org> Wed Oct 26 21:29:52 2022 -0700
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 31 10:39:13 2022 +0000
tree 2c5e47d45de80d600b67defb473a400657a0669e
parent 39525089de13a80d658856c1834d0d10ab47b667

check_ethernet.hook: fix lint warnings

Make sure variables are double quoted.

BUG=none
TEST=repo upload .

Change-Id: Ib4f819bd6eaf2798982607dd144ae51e53ccbfed
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crostestutils/+/3985052
Commit-Queue: Grant Grundler <grundler@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>

recover_duts/hooks/check_ethernet.hook

diff --git a/recover_duts/hooks/check_ethernet.hook b/recover_duts/hooks/check_ethernet.hook
index fbf17e3..fb2cb52 100755
--- a/recover_duts/hooks/check_ethernet.hook
+++ b/recover_duts/hooks/check_ethernet.hook
@@ -111,20 +111,20 @@
   local default_gateway
   default_gateway="$(get_default_gateway)" || default_gateway=
   if [ -n "${default_gateway}" ]; then
-    do_ping ${default_gateway} && return 0
+    do_ping "${default_gateway}" && return 0
   fi
 
   local ssh_client
   ssh_client="$(find_ssh_client)" || ssh_client=
   if [ -n "${ssh_client}" ]; then
-    do_ping ${ssh_client} && return 0
+    do_ping "${ssh_client}" && return 0
   fi
 
   # Last attempt: any recently seen neighbor
   local neighbor
   neighbor="$(find_ethernet_neighbor)" || neighbor=
   if [ -n "${neighbor}" ]; then
-    do_ping ${neighbor} && return 0
+    do_ping "${neighbor}" && return 0
   fi
   return 1
 }
@@ -137,7 +137,7 @@
     reload_network_device "${eth}"
     ret=0
   done
-  return ${ret}
+  return "${ret}"
 }
 
 toggle_usb_ports() {
@@ -164,7 +164,7 @@
       sleep 1
     fi
   done
-  return ${ret}
+  return "${ret}"
 }
 
 # If there are no devices available, rescan all hubs.
@@ -275,7 +275,7 @@
     return 1
   fi
 
-  if [ ${paused_time} -gt $((30*60)) ] ; then
+  if [ "${paused_time}" -gt $((30*60)) ] ; then
     critical_msg "Pause request exceeded 30 minutes. Checking lab network link."
     force_pause_lock
     return 1