commit 1719fbb82b87d1af096e1be5ecfb0ce955f2f5cc
author Mike Truty <truty@chromium.org> Thu Nov 29 11:26:11 2012 -0600
committer Gerrit <chrome-bot@google.com> Fri Nov 30 04:32:04 2012 -0800
tree bd11571ba1c3da0f41327d848bf9aae390e60e7c
parent 63a3a44cf8fa41c50a5f258d90369b30e5126a4f

Add file_size to make debugging large files easier.

Make it easier to notice large core and messages files
that are consuming GB of space under sysinfo folders.

BUG=chromium-os:36326
TEST=http://cargocult.mtv:8080/logs/run_remote_tests.Qt5p/
TEST=many files under: http://cargocult.mtv:8080/

Change-Id: I5adc2b56b92be4143f2a9ba96922af28e5f99274
Reviewed-on: https://gerrit.chromium.org/gerrit/38918
Reviewed-by: Yusuf Mohsinally <mohsinally@google.com>
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Commit-Ready: Mike Truty <truty@chromium.org>
Tested-by: Mike Truty <truty@chromium.org>

utils_py/local_dash/dash_template/result_viewer

diff --git a/utils_py/local_dash/dash_template/result_viewer b/utils_py/local_dash/dash_template/result_viewer
index 28a795d..2b14cb3 100755
--- a/utils_py/local_dash/dash_template/result_viewer
+++ b/utils_py/local_dash/dash_template/result_viewer
@@ -109,11 +109,12 @@
     is_dir = os.path.isdir(dir_or_file)
     dir_or_file_link = _make_local_link(dir_or_file[len_prefix:],
                                         is_dir=is_dir)
+    file_size = os.stat(dir_or_file).st_size if not is_dir else '-'
     unformatted = time.localtime(os.stat(dir_or_file).st_mtime)
     dir_or_file_time = time.strftime("%a, %d %b %Y %H:%M:%S", unformatted)
     # Use 'd' to indicate directory vs '-' for a file.
     body_lines.append(['d' if is_dir else '-', dir_or_file_link,
-                       dir_or_file_time, unformatted])
+                       dir_or_file_time, unformatted, file_size])
     # Sort reverse-chronological top-down to see latest first.
     body_lines = sorted(body_lines, key=operator.itemgetter(3), reverse=True)
   return bottle.template('dir_view', filepath=filepath, body_lines=body_lines)

utils_py/local_dash/dash_template/views/dir_view.tpl

diff --git a/utils_py/local_dash/dash_template/views/dir_view.tpl b/utils_py/local_dash/dash_template/views/dir_view.tpl
index 9db7592..a0aceea 100644
--- a/utils_py/local_dash/dash_template/views/dir_view.tpl
+++ b/utils_py/local_dash/dash_template/views/dir_view.tpl
@@ -10,12 +10,14 @@
       <tr>
         <th>&nbsp;</th>
         <th style="text-align:left">Name</th>
+        <th style="text-align:left">Size</th>
         <th style="text-align:right">Date Modified</th>
       </tr>
-      %for is_dir, link_part, time_part, _ in body_lines:
+      %for is_dir, link_part, time_part, _, size_part in body_lines:
         <tr>
         <td>{{is_dir}}</td>
         <td style="text-align:left">{{!link_part}}</td>
+        <td style="text-align:left">{{size_part}}</td>
         <td style="padding-left:20px">{{time_part}}</td>
         </tr>
       %end