chromeos-chrome: Add USE flag to enable DCHECKs in Chrome
Add the "chrome_dcheck" USE flag to provide the ability to set the
"dcheck_always_on=true" build argument. This is necessary to spin
up CrOS builders to test Chrome DCHECKs on CrOS. See
go/chrome-dcheck-on-cros for more information.
BUG=b:174866377
TEST=cros_sdk --chrome_root=${PATH_TO_CHROMIUM_SRC} --goma_dir=~/depot_tools/.cipd_bin
cros_workon --board ${BOARD} start chromeos-chrome chrome-icu
export USE="chrome_internal chrome_dcheck goma" && emerge-${BOARD} chromeos-chrome
Change-Id: I52d7c249a24a63f5f5eb158417bc4ce48f313eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2583494
Tested-by: Mike Wiitala <mwiitala@google.com>
Auto-Submit: Mike Wiitala <mwiitala@google.com>
Commit-Queue: Mike Wiitala <mwiitala@google.com>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
diff --git a/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild b/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
index 89e8f31..5884d07 100644
--- a/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
+++ b/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
@@ -38,6 +38,7 @@
+cfi
cfm
chrome_debug_tests
+ chrome_dcheck
chrome_internal
chrome_media
+chrome_remoting
@@ -409,6 +410,10 @@
append-flags -fno-split-dwarf-inlining
fi
fi
+
+ if use chrome_dcheck; then
+ BUILD_ARGS+=("dcheck_always_on=true")
+ fi
}
unpack_chrome() {
@@ -1341,7 +1346,7 @@
# Non-internal builds come with >10MB of unwinding info built-in. Size
# checks on those are less profitable.
- if [[ ${CHROME_SIZE} -ge 250000000 && -z "${KEEP_CHROME_DEBUG_SYMBOLS}" ]] && use chrome_internal; then
+ if [[ ${CHROME_SIZE} -ge 250000000 && -z "${KEEP_CHROME_DEBUG_SYMBOLS}" ]] && use chrome_internal && ! use chrome_dcheck; then
die "Installed chrome binary got suspiciously large (size=${CHROME_SIZE})."
fi
if use arm; then
