commit 615f981fabb4e69f902e6797744804f312eb4a2f
author Ryan Cui <rcui@chromium.org> Mon Aug 05 16:41:35 2013 -0700
committer ChromeBot <chrome-bot@google.com> Tue Aug 06 18:55:32 2013 -0700
tree a26bc38f82a640975ec456d73fc9ca80e8a305a0
parent de21f48ab89ad6299dfef1fc32d5295c6dc1569b

Fix bug in custom version key generation.

Instead of using '%' which is a shell special character, and may be
expanded in certain cases, use the safer '__' separator.  We use double
underscore for better readability.

BUG=None
TEST=Ran on a buildbot and locally.

Change-Id: If82f74effc3f977f5e58d543a097198688347e21
Reviewed-on: https://gerrit.chromium.org/gerrit/64711
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ryan Cui <rcui@chromium.org>
Tested-by: Ryan Cui <rcui@chromium.org>

cros/commands/cros_chrome_sdk.py

diff --git a/cros/commands/cros_chrome_sdk.py b/cros/commands/cros_chrome_sdk.py
index 730e39f..53574fe 100644
--- a/cros/commands/cros_chrome_sdk.py
+++ b/cros/commands/cros_chrome_sdk.py
@@ -270,7 +270,7 @@
     """Builds the cache key tuple for an SDK component."""
     version_section = version
     if self.sdk_path is not None:
-      version_section = self.sdk_path.replace('/', '%')
+      version_section = self.sdk_path.replace('/', '__')
     return (self.board, version_section, component)
 
   @contextlib.contextmanager