Skip PromoteCandidate on debug builds.
When testing the commit queue locally, the tests currently fail with
'Candidate not found locally' errors. We should fix this as it blocks full
testing of the CommitQueueCompletion stage.
Long term, we should enable debug mode testing of this stage, so I've
added a TODO for that.
BUG=chromium-os:33131
TEST=Remote trybot run of mario-paladin with --buildbot --debug
Change-Id: I4967830af4998799af894cb52219809ac727f28b
Reviewed-on: https://gerrit.chromium.org/gerrit/28884
Tested-by: David James <davidjames@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Ready: David James <davidjames@chromium.org>
diff --git a/buildbot/cbuildbot_stages.py b/buildbot/cbuildbot_stages.py
index 69a4d01..76d134f 100644
--- a/buildbot/cbuildbot_stages.py
+++ b/buildbot/cbuildbot_stages.py
@@ -715,7 +715,9 @@
def HandleSuccess(self):
# We only promote for the pfq, not chrome pfq.
- if (cbuildbot_config.IsPFQType(self._build_config['build_type']) and
+ # TODO(build): Run this logic in debug mode too.
+ if (not self._options.debug and
+ cbuildbot_config.IsPFQType(self._build_config['build_type']) and
self._build_config['master'] and
self._target_manifest_branch == 'master' and
ManifestVersionedSyncStage.manifest_manager != None and
