lint: flag optparse as deprecated
We want people to use chromite.lib.commandline or at least argparse.
Mark optparse as deprecated so people won't write new code with it.
BUG=None
TEST=`cros lint` doesn't show any new warnings (after adding markers)
Change-Id: Iaf295e711b5e855e80b7a084765d19b4f5118fb9
Reviewed-on: https://chromium-review.googlesource.com/311091
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/cbuildbot/cbuildbot_unittest.py b/cbuildbot/cbuildbot_unittest.py
index c17bb78..8362e6e 100644
--- a/cbuildbot/cbuildbot_unittest.py
+++ b/cbuildbot/cbuildbot_unittest.py
@@ -8,7 +8,7 @@
import argparse
import glob
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
from chromite.cbuildbot import cbuildbot_run
diff --git a/lib/commandline.py b/lib/commandline.py
index 8a75ce8..3855331 100644
--- a/lib/commandline.py
+++ b/lib/commandline.py
@@ -15,7 +15,7 @@
import datetime
import functools
import os
-import optparse
+import optparse # pylint: disable=deprecated-module
import signal
import sys
import urlparse
diff --git a/pylintrc b/pylintrc
index 0fc12be..452453b 100644
--- a/pylintrc
+++ b/pylintrc
@@ -268,7 +268,7 @@
[IMPORTS]
# Deprecated modules which should not be used, separated by a comma
-#deprecated-modules=regsub,string,TERMIOS,Bastion,rexec
+deprecated-modules=regsub,TERMIOS,Bastion,rexec,optparse
# Create a graph of every (i.e. internal and external) dependencies in the
# given file (report RP0402 must not be disabled)
diff --git a/scripts/cbuildbot.py b/scripts/cbuildbot.py
index baf0387..3d89ca7 100644
--- a/scripts/cbuildbot.py
+++ b/scripts/cbuildbot.py
@@ -14,7 +14,7 @@
import glob
import json
import mock
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import pickle
import sys
diff --git a/scripts/cros_generate_deps_graphs.py b/scripts/cros_generate_deps_graphs.py
index 17244bd..e39d0c8 100644
--- a/scripts/cros_generate_deps_graphs.py
+++ b/scripts/cros_generate_deps_graphs.py
@@ -7,7 +7,7 @@
from __future__ import print_function
import json
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import sys
diff --git a/scripts/cros_generate_local_binhosts.py b/scripts/cros_generate_local_binhosts.py
index 3bed5d2..ad9b821 100644
--- a/scripts/cros_generate_local_binhosts.py
+++ b/scripts/cros_generate_local_binhosts.py
@@ -12,7 +12,7 @@
import collections
import glob
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import sys
diff --git a/scripts/cros_mark_chrome_as_stable.py b/scripts/cros_mark_chrome_as_stable.py
index d5cebf5..203ab03 100644
--- a/scripts/cros_mark_chrome_as_stable.py
+++ b/scripts/cros_mark_chrome_as_stable.py
@@ -19,7 +19,7 @@
import base64
import distutils.version
import filecmp
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import re
import sys
diff --git a/scripts/loman.py b/scripts/loman.py
index d068c4e..fc26be2 100644
--- a/scripts/loman.py
+++ b/scripts/loman.py
@@ -7,7 +7,7 @@
from __future__ import print_function
import platform
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import sys
import xml.etree.ElementTree as ElementTree
diff --git a/scripts/merge_package_status.py b/scripts/merge_package_status.py
index 018f8e3..b350723 100644
--- a/scripts/merge_package_status.py
+++ b/scripts/merge_package_status.py
@@ -9,7 +9,7 @@
from __future__ import print_function
-import optparse
+import optparse # pylint: disable=deprecated-module
import os
import re
