commit 6f3a0ae4ded9adc9b828d25c39422ca63fd12658
author Fergus Dall <sidereal@google.com> Wed Sep 16 14:24:48 2020 +1000
committer Commit Bot <commit-bot@chromium.org> Wed Sep 16 16:43:26 2020 +0000
tree 88852828f857fea7571e35f40127daad9e2be5ca
parent b82a1e239de5cfca1beeeb54ea214e461883305f

chromite: Stop uploading debug symbols in tatl/tael-full builders

This never actually did what we wanted it to do, since for
non-official builds (like the full builders) this option only uploads
to the staging crash server, not the prod crash server. For our
current uprev setup uploading crash symbols is done with a manual
script, and when we switch over to fully automated uprevs we won't be
using the output of these full builders regardless.

BUG=chromium:1128741
TEST=./config/refresh_generated_files

Change-Id: I84e9e60da8690222bc4eed42ec4a21bc3a7a896b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2413313
Tested-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Navil Perez <navil@google.com>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>
Reviewed-by: Navil Perez <navil@google.com>
Auto-Submit: Fergus Dall <sidereal@google.com>

config/chromeos_config.py

diff --git a/config/chromeos_config.py b/config/chromeos_config.py
index 1340163..89734e7 100644
--- a/config/chromeos_config.py
+++ b/config/chromeos_config.py
@@ -1405,13 +1405,6 @@
       'tatl',
   ])
 
-  # These full builders are used to produce released VMs and so need to upload
-  # debug symbols to the crash server.
-  symbol_upload_builders = frozenset([
-      'tael',
-      'tatl',
-  ])
-
   # Move the following builders to active_builders once they are consistently
   # green.
   unstable_builders = frozenset([
@@ -1446,12 +1439,6 @@
       schedule='0 */3 * * *',
   )
 
-  site_config.ApplyForBoards(
-      config_lib.CONFIG_TYPE_FULL,
-      symbol_upload_builders,
-      upload_symbols=True,
-  )
-
   master_config.AddSlaves(
       site_config.ApplyForBoards(
           config_lib.CONFIG_TYPE_FULL,

config/config_dump.json

diff --git a/config/config_dump.json b/config/config_dump.json
index cb50ed9..7e2aa06 100644
--- a/config/config_dump.json
+++ b/config/config_dump.json
@@ -29952,7 +29952,6 @@
         "upload_stripped_packages": [
             "sys-kernel/*kernel*"
         ],
-        "upload_symbols": true,
         "useflags": [
             "-chrome_internal"
         ],
@@ -29990,7 +29989,6 @@
         "upload_stripped_packages": [
             "sys-kernel/*kernel*"
         ],
-        "upload_symbols": true,
         "useflags": [
             "-chrome_internal"
         ],
@@ -30169,7 +30167,6 @@
         "upload_stripped_packages": [
             "sys-kernel/*kernel*"
         ],
-        "upload_symbols": true,
         "useflags": [
             "-chrome_internal"
         ],
@@ -30207,7 +30204,6 @@
         "upload_stripped_packages": [
             "sys-kernel/*kernel*"
         ],
-        "upload_symbols": true,
         "useflags": [
             "-chrome_internal"
         ],