commit 57a7b133e1a9e359dcb0fd52bc9ab0118c1f4ad3
author David James <davidjames@chromium.org> Fri Apr 26 15:24:30 2013 -0700
committer ChromeBot <chrome-bot@google.com> Mon Apr 29 12:09:36 2013 -0700
tree d947736a89b81a08190d4c7a0ed1231e6f1421e1
parent 2046b3bab3f8e3db0494df61439990940c2dbef3

Fail remote trybot builds when HWTests time out.

If hwtest times out on a remote trybot, the build should not be marked
as successful, since the build didn't really succeed -- the user asked
to test their change using remote trybots and this didn't really happen.

BUG=chromium:236025
TEST=Unittests.
STATUS=Fixed

Change-Id: I11d990ff02d540b0dda9afedd270ae986dcb23e5
Reviewed-on: https://gerrit.chromium.org/gerrit/49373
Tested-by: David James <davidjames@chromium.org>
Reviewed-by: Ryan Cui <rcui@chromium.org>
Commit-Queue: David James <davidjames@chromium.org>

buildbot/cbuildbot_config.py

diff --git a/buildbot/cbuildbot_config.py b/buildbot/cbuildbot_config.py
index 555e9db..03586ca 100755
--- a/buildbot/cbuildbot_config.py
+++ b/buildbot/cbuildbot_config.py
@@ -76,11 +76,12 @@
       if not my_config['hw_tests']:
         my_config['hw_tests'] = HWTestConfig.DefaultList(
             num=constants.HWTEST_TRYBOT_NUM, pool=constants.HWTEST_TRYBOT_POOL,
-            file_bugs=False)
+            critical=True, file_bugs=False)
       else:
         for hw_config in my_config['hw_tests']:
           hw_config.num = constants.HWTEST_TRYBOT_NUM
           hw_config.pool = constants.HWTEST_TRYBOT_POOL
+          hw_config.critical = True
           hw_config.file_bugs = False
 
     # Default to starting with a fresh chroot on remote trybot runs.