commit 4978088dea32a75d330c4cf8409822406162d538
author Ned Nguyen <nednguyen@google.com> Mon Dec 31 08:36:15 2018 -0700
committer chrome-bot <chrome-bot@chromium.org> Tue Jan 01 02:43:28 2019 -0800
tree d3a2cd4db61ec947fe83337f8ad184ad4da9aa21
parent 8d6203a906fe4e29aee04e72271b92f3b2dda93d

run_tests: Remove stale test file references

This also adds a test in run_test_unittests that makes sure all
the test files specified in SPECIAL_TESTS and SLOW_TESTS exists.

BUG=None
TEST=./scripts/run_test_unittests

Change-Id: I0a77be10db14d71fbac130303d6049a44a345189
Reviewed-on: https://chromium-review.googlesource.com/1387873
Commit-Ready: Ned Nguyen <nednguyen@google.com>
Tested-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

scripts/run_tests.py

diff --git a/scripts/run_tests.py b/scripts/run_tests.py
index 7867928..f9d9dc3 100644
--- a/scripts/run_tests.py
+++ b/scripts/run_tests.py
@@ -70,7 +70,6 @@
     'cli/cros/cros_build_unittest': INSIDE,
     'cli/cros/cros_chroot_unittest': INSIDE,
     'cli/cros/cros_debug_unittest': INSIDE,
-    'cli/cros/cros_payload_unittest': INSIDE,
     'cli/cros/lint_unittest': INSIDE,
     'cli/cros/lint_autotest_unittest': INSIDE,
     'cli/deploy_unittest': INSIDE,
@@ -89,11 +88,9 @@
     'scripts/cros_list_modified_packages_unittest': INSIDE,
     'scripts/cros_mark_as_stable_unittest': INSIDE,
     'scripts/cros_mark_chrome_as_stable_unittest': INSIDE,
-    'scripts/sync_package_status_unittest': INSIDE,
     'scripts/cros_portage_upgrade_unittest': INSIDE,
     'scripts/dep_tracker_unittest': INSIDE,
     'scripts/test_image_unittest': INSIDE,
-    'scripts/upload_package_status_unittest': INSIDE,
 
     # Tests that need to run outside the chroot.
     'lib/cgroups_unittest': OUTSIDE,
@@ -111,9 +108,6 @@
 
 SLOW_TESTS = {
     # Tests that require network can be really slow.
-    'buildbot/manifest_version_unittest': SKIP,
-    'buildbot/repository_unittest': SKIP,
-    'buildbot/remote_try_unittest': SKIP,
     'lib/cros_build_lib_unittest': SKIP,
     'lib/gce_unittest': SKIP,
     'lib/gerrit_unittest': SKIP,

scripts/run_tests_unittest.py

diff --git a/scripts/run_tests_unittest.py b/scripts/run_tests_unittest.py
index 342c839..6e9971c 100644
--- a/scripts/run_tests_unittest.py
+++ b/scripts/run_tests_unittest.py
@@ -10,11 +10,29 @@
 import mock
 import os
 
+from chromite.lib import constants
 from chromite.lib import cros_test_lib
 from chromite.lib import osutils
 from chromite.scripts import run_tests
 
 
+class TestsExceptionsTest(cros_test_lib.TestCase):
+  """Tests that all tests in SPECIAL_TESTS and SLOW_TESTS do exist."""
+
+  def runTest(self):
+    for test_path in run_tests.SPECIAL_TESTS:
+      self.assertExists(
+          os.path.join(constants.CHROMITE_DIR, test_path),
+          "%s doesn't exist. Please remove it from run_tests.SPECIAL_TESTS" %
+          test_path)
+
+    for test_path in run_tests.SLOW_TESTS:
+      self.assertExists(
+          os.path.join(constants.CHROMITE_DIR, test_path),
+          "%s doesn't exist. Please remove it from run_tests.SLOW_TESTS" %
+          test_path)
+
+
 class RunTestsTest(cros_test_lib.MockTestCase):
   """Tests for the RunTests() func"""