commit 2dbe13c8fa7749370483bee883b61c336e49c3ab
author Mike Frysinger <vapier@chromium.org> Wed Nov 25 13:45:31 2020 -0500
committer Commit Bot <commit-bot@chromium.org> Mon Nov 30 18:42:39 2020 +0000
tree b266e74fb09421423ed7463e5144b9857c6daf5a
parent 6cf589a4de24ff7bc88cc08df2b70a3b27bd214e

portage_util: note when we can drop CROS_WORKON_BLACKLIST

Since we use this code with firmware/factory branches, we can't drop
it until those all cycle out.

BUG=chromium:1125947
TEST=CQ passes

Change-Id: Ide2730ad9f5d95a12ed61ce77d6c3d65324afcdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2560219
Tested-by: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
Commit-Queue: Chris McDonald <cjmcdonald@chromium.org>

lib/portage_util.py

diff --git a/lib/portage_util.py b/lib/portage_util.py
index 564ab3c..e3c5731 100644
--- a/lib/portage_util.py
+++ b/lib/portage_util.py
@@ -356,7 +356,8 @@
       r'.*-(([0-9][0-9a-z_.]*)(-r[0-9]+)?)[.]ebuild')
   _WORKON_COMMIT_PATTERN = re.compile(r'^CROS_WORKON_COMMIT=')
 
-  # TODO(crbug.com/1125947): Drop CROS_WORKON_BLACKLIST.
+  # TODO(crbug.com/1125947): Drop CROS_WORKON_BLACKLIST.  We can do this once
+  # we no longer support branches <R89 / 13623.0.0.
   _RE_MANUAL_UPREV = re.compile(
       r"""^CROS_WORKON_(MANUAL_UPREV|BLACKLIST)=(['"])?1\2?$""")