commit 0f7211c78bbe84fe226f0ff70d8ee6dfbc038c80
author Stefan Beller <sbeller@google.com> Fri Jul 17 15:40:41 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Tue Aug 11 19:52:50 2015 +0000
tree f075a471cce4379422754556b29dcdf49bb23183
parent 2b74b30e723fc1b23cd3f91bdb7e5bc4d6ff674a

Use a different legacy id to assume a non existent change

So this test assumes change 12345 to be an invalid change (it's
a pretty huge number after all ;) but today is the day where this change
came into existence.

For now increase the number a bit. Increase
_MAXIMUM_GERRIT_NUMBER_LENGTH by one so we can have up to 1M changes,
giving us a little more headroom.

Change-Id: I1124442cf7fa74a470bb3cce8b185cdd651de5de
Reviewed-on: https://chromium-review.googlesource.com/286548
Reviewed-by: David James <davidjames@chromium.org>
Commit-Queue: Dave Borowitz <dborowitz@google.com>
Tested-by: Dave Borowitz <dborowitz@google.com>
Reviewed-by: Stefan Beller <sbeller@google.com>

lib/gerrit_unittest.py

diff --git a/lib/gerrit_unittest.py b/lib/gerrit_unittest.py
index 6c1af6b..db4845f 100644
--- a/lib/gerrit_unittest.py
+++ b/lib/gerrit_unittest.py
@@ -213,9 +213,9 @@
     self.assertRaises(gerrit.GerritException, gerrit.GetGerritPatchInfo,
                       [gpatch.change_id, invalid_change_id])
     self.assertRaises(gerrit.GerritException, gerrit.GetGerritPatchInfo,
-                      ['12345', gpatch.gerrit_number])
+                      ['9876543', gpatch.gerrit_number])
     self.assertRaises(gerrit.GerritException, gerrit.GetGerritPatchInfo,
-                      [gpatch.gerrit_number, '12345'])
+                      [gpatch.gerrit_number, '9876543'])
 
     # Simple query by project/changeid/sha1.
     patch_info = helper.GrabPatchFromGerrit(gpatch.project, gpatch.change_id,

lib/patch.py

diff --git a/lib/patch.py b/lib/patch.py
index 8c8a47e..e75207a 100644
--- a/lib/patch.py
+++ b/lib/patch.py
@@ -32,7 +32,7 @@
   mock = None
 
 
-_MAXIMUM_GERRIT_NUMBER_LENGTH = 6
+_MAXIMUM_GERRIT_NUMBER_LENGTH = 7
 _GERRIT_CHANGE_ID_PREFIX = 'I'
 _GERRIT_CHANGE_ID_LENGTH = 40
 _GERRIT_CHANGE_ID_TOTAL_LENGTH = (_GERRIT_CHANGE_ID_LENGTH +

lib/patch_unittest.py

diff --git a/lib/patch_unittest.py b/lib/patch_unittest.py
index 8488193..a3f2c4c 100644
--- a/lib/patch_unittest.py
+++ b/lib/patch_unittest.py
@@ -407,7 +407,7 @@
     # we're using shortened versions).
     self.assertRaises(cros_patch.BrokenCQDepends,
                       self._CheckPaladin, git1, cid1,
-                      ['1234567'], 'CQ-DEPEND=%s' % '1234567')
+                      ['123456789'], 'CQ-DEPEND=%s' % '123456789')
     # Single key, gerrit number, internal.
     self._CheckPaladin(git1, cid1, ['*123'],
                        'CQ-DEPEND=%s' % '*123')
@@ -992,7 +992,7 @@
       self.assertTrue(cros_patch.ParsePatchDep(val) is not None)
 
     self._assertBad(cros_patch.ParsePatchDep,
-                    ['1454623', 'I47ea3', 'i47ea3'.ljust(41, '0')])
+                    ['145462399', 'I47ea3', 'i47ea3'.ljust(41, '0')])
 
 
 class MockPatchBase(cros_test_lib.MockTestCase):