dependency_lib: New lib for dependency functionality.
Many of the functions in service/dependency contain too many
implementation details for a service/, and contain functionality
we want in other libs/. Start moving those functions to the new
dependency_lib.
BUG=chromium:1135361
TEST=None
Change-Id: I5e7093ab2d22e55871a9f05949f3cdae500469f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2605342
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Alex Klein <saklein@chromium.org>
diff --git a/lib/dependency_lib.py b/lib/dependency_lib.py
new file mode 100644
index 0000000..378d677
--- /dev/null
+++ b/lib/dependency_lib.py
@@ -0,0 +1,261 @@
+# Copyright 2020 The Chromium OS Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Dependency calculation functionality/utilities."""
+
+import os
+import re
+
+from chromite.lib import constants
+from chromite.lib import cros_logging as logging
+from chromite.lib import git
+from chromite.lib import osutils
+from chromite.lib import portage_util
+
+
+class Error(Exception):
+ """Base error class for the module."""
+
+
+class MissingCacheEntry(Error):
+ """No on-disk cache entry could be found for a package."""
+
+
+class NoMatchingFileForDigest(Error):
+ """No ebuild or eclass file could be found with the given MD5 digest."""
+
+
+def normalize_source_paths(source_paths):
+ """Return the "normalized" form of a list of source paths.
+
+ Normalizing includes:
+ * Sorting the source paths in alphabetical order.
+ * Remove paths that are sub-path of others in the source paths.
+ * Ensure all the directory path strings are ended with the trailing '/'.
+ * Convert all the path from absolute paths to relative path (relative to
+ the chroot source root).
+ """
+ for i, path in enumerate(source_paths):
+ assert os.path.isabs(path), 'path %s is not an aboslute path' % path
+ source_paths[i] = os.path.normpath(path)
+
+ source_paths.sort()
+
+ results = []
+
+ for i, path in enumerate(source_paths):
+ is_subpath_of_other = False
+ for j, other in enumerate(source_paths):
+ if j != i and osutils.IsSubPath(path, other):
+ is_subpath_of_other = True
+ if not is_subpath_of_other:
+ if os.path.isdir(path) and not path.endswith('/'):
+ path += '/'
+ path = os.path.relpath(path, constants.SOURCE_ROOT)
+ results.append(path)
+
+ return results
+
+
+def _get_eclasses_for_ebuild(ebuild_path, path_cache, overlay_dirs):
+ # Trim '.ebuild' from the tail of the path.
+ ebuild_path_no_ext, _ = os.path.splitext(ebuild_path)
+
+ # Ebuild paths look like:
+ # {some_dir}/category/package/package-version
+ # but cache entry paths look like:
+ # {some_dir}/category/package-version
+ # So we need to remove the second to last path element from the ebuild path
+ # to construct the path to the matching edb cache entry.
+ path_head, package_name = os.path.split(ebuild_path_no_ext)
+ path_head, _ = os.path.split(path_head)
+ overlay_head, category = os.path.split(path_head)
+ fixed_path = os.path.join(overlay_head, category, package_name)
+
+ cache_file_relpath = os.path.relpath(fixed_path, '/')
+
+ edb_cache_file_path = os.path.join('/var/cache/edb/dep', cache_file_relpath)
+ md5_cache_file_path = os.path.join(overlay_head, 'metadata', 'md5-cache',
+ category, package_name)
+
+ if os.path.isfile(edb_cache_file_path):
+ cache_entries = _parse_ebuild_cache_entry(edb_cache_file_path)
+ elif os.path.isfile(md5_cache_file_path):
+ cache_entries = _parse_ebuild_cache_entry(md5_cache_file_path)
+ else:
+ raise MissingCacheEntry(
+ 'No cache entry found for package: %s' % package_name)
+
+ relevant_eclass_paths = []
+ for eclass, digest in cache_entries:
+ if digest in path_cache:
+ relevant_eclass_paths.append(path_cache[digest])
+ else:
+ try:
+ eclass_path = _find_matching_eclass_file(eclass, digest, overlay_dirs)
+ path_cache[digest] = eclass_path
+ relevant_eclass_paths.append(eclass_path)
+ except NoMatchingFileForDigest:
+ logging.warning(
+ ('Package %s has a reference to eclass %s with digest %s but no '
+ 'matching file could be found.'), package_name, eclass, digest)
+ # If we can't find a matching eclass file then we don't know exactly
+ # which overlay the eclass file is coming from, but we do know that it
+ # has to be in one of the overlay_dirs. So as a fallback we will pretend
+ # the eclass could be in any of them and add all of the paths that it
+ # could possibly have.
+ relevant_eclass_paths.extend([
+ os.path.join(overlay, 'eclass', eclass) + '.eclass'
+ for overlay in overlay_dirs
+ ])
+
+ return relevant_eclass_paths
+
+
+def _find_matching_eclass_file(eclass, digest, overlay_dirs):
+ for overlay in overlay_dirs:
+ path = os.path.join(overlay, 'eclass', eclass) + '.eclass'
+ if os.path.isfile(path) and digest == osutils.MD5HashFile(path):
+ return path
+ raise NoMatchingFileForDigest(
+ 'No matching eclass file found: %s %s' % (eclass, digest))
+
+
+def _parse_ebuild_cache_entry(cache_file_path):
+ """Extract the eclasses with their digest from an ebuild's cache file."""
+ eclass_regex = re.compile(r'_eclasses_=(.*)')
+ eclass_clause_regex = (
+ # The eclass name, e.g. cros-workon.
+ r'(?P<eclass>[^\s]+)\s+'
+ # The edb cache files contain the overlay path, the md5 cache file does
+ # not, so optionally parse the path.
+ r'((?P<overlay_path>[^\s]+)\s+)?'
+ # The eclass digest followed by a word boundary -- \b prevents parsing md5
+ # digests as paths when the next class begins with a-f.
+ r'(?P<digest>[\da-fA-F]+)\b\s*')
+
+ cachefile = osutils.ReadFile(cache_file_path)
+ m = eclass_regex.search(cachefile)
+ if not m:
+ return []
+
+ start, end = m.start(1), m.end(1)
+ entries = re.finditer(eclass_clause_regex, cachefile[start:end])
+ return [(c.group('eclass'), c.group('digest')) for c in entries]
+
+
+def get_source_path_mapping(packages, sysroot_path, board):
+ """Returns a map from each package to the source paths it depends on.
+
+ A source path is considered dependency of a package if modifying files in that
+ path might change the content of the resulting package.
+
+ Notes:
+ 1) This method errs on the side of returning unneeded dependent paths.
+ i.e: for a given package X, some of its dependency source paths may
+ contain files which doesn't affect the content of X.
+
+ On the other hands, any missing dependency source paths for package X is
+ considered a bug.
+ 2) This only outputs the direct dependency source paths for a given package
+ and does not takes include the dependency source paths of dependency
+ packages.
+ e.g: if package A depends on B (DEPEND=B), then results of computing
+ dependency source paths of A doesn't include dependency source paths
+ of B.
+
+ Args:
+ packages: The list of packages CPV names (str)
+ sysroot_path (str): The path to the sysroot. If the packages are board
+ agnostic, then this should be '/'.
+ board (str): The name of the board if packages are dependency of board. If
+ the packages are board agnostic, then this should be None.
+
+ Returns:
+ Map from each package to the source path (relative to the repo checkout
+ root, i.e: ~/trunk/ in your cros_sdk) it depends on.
+ For each source path which is a directory, the string is ended with a
+ trailing '/'.
+ """
+ results = {}
+
+ packages_to_ebuild_paths = portage_util.FindEbuildsForPackages(
+ packages, sysroot=sysroot_path, check=True)
+
+ # Source paths which are the directory of ebuild files.
+ for package, ebuild_path in packages_to_ebuild_paths.items():
+ # Include the entire directory that contains the ebuild as the package's
+ # FILESDIR probably lives there too.
+ results[package] = [os.path.dirname(ebuild_path)]
+
+ # Source paths which are cros workon source paths.
+ buildroot = os.path.join(constants.SOURCE_ROOT, 'src')
+ manifest = git.ManifestCheckout.Cached(buildroot)
+ for package, ebuild_path in packages_to_ebuild_paths.items():
+ attrs = portage_util.EBuild.Classify(ebuild_path)
+ if (not attrs.is_workon or
+ # Blacklisted ebuild is pinned to a specific git sha1, so change in
+ # that repo matter to the ebuild.
+ attrs.is_blacklisted):
+ continue
+ ebuild = portage_util.EBuild(ebuild_path)
+ workon_subtrees = ebuild.GetSourceInfo(buildroot, manifest).subtrees
+ for path in workon_subtrees:
+ results[package].append(path)
+
+ if board:
+ overlay_directories = portage_util.FindOverlays(
+ overlay_type='both', board=board)
+ else:
+ # If a board is not specified we assume the package is intended for the SDK
+ # and so we use the overlays for the SDK builder.
+ overlay_directories = portage_util.FindOverlays(
+ overlay_type='both', board=constants.CHROOT_BUILDER_BOARD)
+
+ eclass_path_cache = {}
+
+ for package, ebuild_path in packages_to_ebuild_paths.items():
+ eclass_paths = _get_eclasses_for_ebuild(ebuild_path, eclass_path_cache,
+ overlay_directories)
+ results[package].extend(eclass_paths)
+
+ # Source paths which are the overlay directories for the given board
+ # (packages are board specific).
+
+ # The only parts of the overlay that affect every package are the current
+ # profile (which lives somewhere in the profiles/ subdir) and a top-level
+ # make.conf (if it exists).
+ profile_directories = [
+ os.path.join(x, 'profiles') for x in overlay_directories
+ ]
+ make_conf_paths = [os.path.join(x, 'make.conf') for x in overlay_directories]
+
+ # These directories *might* affect a build, so we include them for now to
+ # be safe.
+ metadata_directories = [
+ os.path.join(x, 'metadata') for x in overlay_directories
+ ]
+ scripts_directories = [
+ os.path.join(x, 'scripts') for x in overlay_directories
+ ]
+
+ for package in results:
+ results[package].extend(profile_directories)
+ results[package].extend(make_conf_paths)
+ results[package].extend(metadata_directories)
+ results[package].extend(scripts_directories)
+ # The 'crosutils' repo potentially affects the build of every package.
+ results[package].append(constants.CROSUTILS_DIR)
+
+ # chromiumos-overlay specifies default settings for every target in
+ # chromeos/config and so can potentially affect every board.
+ for package in results:
+ results[package].append(
+ os.path.join(constants.CHROOT_SOURCE_ROOT,
+ constants.CHROMIUMOS_OVERLAY_DIR, 'chromeos', 'config'))
+
+ for p in results:
+ results[p] = normalize_source_paths(results[p])
+
+ return results
diff --git a/lib/dependency_lib_unittest.py b/lib/dependency_lib_unittest.py
new file mode 100644
index 0000000..7c2d4d6
--- /dev/null
+++ b/lib/dependency_lib_unittest.py
@@ -0,0 +1,104 @@
+# Copyright 2020 The Chromium OS Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Tests for dependency_lib."""
+
+import os
+
+from chromite.lib import constants
+from chromite.lib import dependency_lib
+from chromite.lib import osutils
+
+
+def test_normalize_source_paths_collapsing_sub_paths():
+ """Test normalize produces"""
+ actual_paths = dependency_lib.normalize_source_paths(
+ [os.path.join(constants.SOURCE_ROOT, 'foo'),
+ os.path.join(constants.SOURCE_ROOT, 'ab', 'cd'),
+ os.path.join(constants.SOURCE_ROOT, 'foo', 'bar')])
+ expected_paths = {'ab/cd', 'foo'}
+ assert set(actual_paths) == expected_paths
+
+ actual_paths = dependency_lib.normalize_source_paths([
+ os.path.join(constants.SOURCE_ROOT, 'foo', 'bar'),
+ os.path.join(constants.SOURCE_ROOT, 'ab', 'cd'),
+ os.path.join(constants.SOURCE_ROOT, 'foo', 'bar', '..'),
+ os.path.join(constants.SOURCE_ROOT, 'ab', 'cde'),
+ ])
+ expected_paths = {'ab/cd', 'ab/cde', 'foo'}
+ assert set(actual_paths) == expected_paths
+
+
+def test_normalize_source_paths_formatting_directory_paths():
+ with osutils.TempDir() as tempdir:
+ foo_dir = os.path.join(tempdir, 'foo')
+ bar_baz_dir = os.path.join(tempdir, 'bar', 'baz')
+ osutils.SafeMakedirs(os.path.join(tempdir, 'ab'))
+ ab_cd_file = os.path.join(tempdir, 'ab', 'cd')
+
+ osutils.SafeMakedirs(foo_dir)
+ osutils.SafeMakedirs(bar_baz_dir)
+ osutils.WriteFile(ab_cd_file, 'alphabet')
+
+ expected_paths = [ab_cd_file, bar_baz_dir + '/', foo_dir + '/']
+ expected_paths = [os.path.relpath(p, constants.SOURCE_ROOT) for
+ p in expected_paths]
+
+ actual_paths = dependency_lib.normalize_source_paths(
+ [foo_dir, ab_cd_file, bar_baz_dir])
+ assert actual_paths == expected_paths
+
+
+def test_parse_ebuild_cache_entry_md5_cache(tmp_path):
+ """Verify parsing eclasses from md5 cache style files."""
+ expected = [
+ ('eclass1', 'abc123'),
+ ('eclass2', '123abc'),
+ ('eclass3', 'def789'),
+ ]
+ eclass_str = '\t'.join('\t'.join(x) for x in expected)
+ contents = f"""
+KEYWORDS=*
+LICENSE=license
+PROPERTIES=live
+RDEPEND=>=foo/bar-0.0.1:= foo/baz:=
+SLOT=0/0
+_eclasses_={eclass_str}
+_md5=123456
+"""
+
+ cache_file = os.path.join(tmp_path, 'cache_file')
+ osutils.WriteFile(cache_file, contents)
+
+ # pylint: disable=protected-access
+ result = dependency_lib._parse_ebuild_cache_entry(cache_file)
+
+ assert set(expected) == set(result)
+
+
+def test_parse_ebuild_cache_entry_edb_cache(tmp_path):
+ """Verify parsing eclasses from edb cache style files."""
+ expected = [
+ ('eclass1', 'abc123'),
+ ('eclass2', '123abc'),
+ ('eclass3', 'def789'),
+ ]
+ eclass_str = '\t'.join('\t'.join((c, '/some/path', d)) for (c, d) in expected)
+ contents = f"""
+KEYWORDS=*
+LICENSE=license
+PROPERTIES=live
+RDEPEND=>=foo/bar-0.0.1:= foo/baz:=
+SLOT=0/0
+_eclasses_={eclass_str}
+_md5=123456
+"""
+
+ cache_file = os.path.join(tmp_path, 'cache_file')
+ osutils.WriteFile(cache_file, contents)
+
+ # pylint: disable=protected-access
+ result = dependency_lib._parse_ebuild_cache_entry(cache_file)
+
+ assert set(expected) == set(result)
diff --git a/service/dependency.py b/service/dependency.py
index 0ac2f91..3b4b9d0 100644
--- a/service/dependency.py
+++ b/service/dependency.py
@@ -10,15 +10,13 @@
import functools
import os
from pathlib import Path
-import re
from typing import List, Optional
from chromite.lib import build_target_lib
from chromite.lib import constants
from chromite.lib import cros_build_lib
-from chromite.lib import cros_logging
+from chromite.lib import dependency_lib
from chromite.lib import git
-from chromite.lib import osutils
from chromite.lib import portage_util
from chromite.scripts import cros_extract_deps
@@ -27,14 +25,6 @@
"""Base error class for the module."""
-class MissingCacheEntry(Error):
- """No on-disk cache entry could be found for a package."""
-
-
-class NoMatchingFileForDigest(Error):
- """No ebuild or eclass file could be found with the given MD5 digest."""
-
-
def NormalizeSourcePaths(source_paths):
"""Return the "normalized" form of a list of source paths.
@@ -45,114 +35,7 @@
* Convert all the path from absolute paths to relative path (relative to
the chroot source root).
"""
- for i, path in enumerate(source_paths):
- assert os.path.isabs(path), 'path %s is not an aboslute path' % path
- source_paths[i] = os.path.normpath(path)
-
- source_paths.sort()
-
- results = []
-
- for i, path in enumerate(source_paths):
- is_subpath_of_other = False
- for j, other in enumerate(source_paths):
- if j != i and osutils.IsSubPath(path, other):
- is_subpath_of_other = True
- if not is_subpath_of_other:
- if os.path.isdir(path) and not path.endswith('/'):
- path += '/'
- path = os.path.relpath(path, constants.CHROOT_SOURCE_ROOT)
- results.append(path)
-
- return results
-
-
-def GetRelevantEclassesForEbuild(ebuild_path, path_cache, overlay_dirs):
-
- # Trim '.ebuild' from the tail of the path.
- ebuild_path_no_ext, _ = os.path.splitext(ebuild_path)
-
- # Ebuild paths look like:
- # {some_dir}/category/package/package-version
- # but cache entry paths look like:
- # {some_dir}/category/package-version
- # So we need to remove the second to last path element from the ebuild path
- # to construct the path to the matching edb cache entry.
- path_head, package_name = os.path.split(ebuild_path_no_ext)
- path_head, _ = os.path.split(path_head)
- overlay_head, category = os.path.split(path_head)
- fixed_path = os.path.join(overlay_head, category, package_name)
-
- cache_file_relpath = os.path.relpath(fixed_path, '/')
-
- edb_cache_file_path = os.path.join('/var/cache/edb/dep', cache_file_relpath)
- md5_cache_file_path = os.path.join(overlay_head, 'metadata', 'md5-cache',
- category, package_name)
-
- if os.path.isfile(edb_cache_file_path):
- cache_entries = _parse_ebuild_cache_entry(edb_cache_file_path)
- elif os.path.isfile(md5_cache_file_path):
- cache_entries = _parse_ebuild_cache_entry(md5_cache_file_path)
- else:
- raise MissingCacheEntry(
- 'No cache entry found for package: %s' % package_name)
-
- relevant_eclass_paths = []
- for eclass, digest in cache_entries:
- if digest in path_cache:
- relevant_eclass_paths.append(path_cache[digest])
- else:
- try:
- eclass_path = find_matching_eclass_file(eclass, digest, overlay_dirs)
- path_cache[digest] = eclass_path
- relevant_eclass_paths.append(eclass_path)
- except NoMatchingFileForDigest:
- cros_logging.warning(
- ('Package %s has a reference to eclass %s with digest %s but no '
- 'matching file could be found.'), package_name, eclass, digest)
- # If we can't find a matching eclass file then we don't know exactly
- # which overlay the eclass file is coming from, but we do know that it
- # has to be in one of the overlay_dirs. So as a fallback we will pretend
- # the eclass could be in any of them and add all of the paths that it
- # could possibly have.
- relevant_eclass_paths.extend([
- os.path.join(overlay, 'eclass', eclass) + '.eclass'
- for overlay in overlay_dirs
- ])
-
- return relevant_eclass_paths
-
-
-def find_matching_eclass_file(eclass, digest, overlay_dirs):
- for overlay in overlay_dirs:
- path = os.path.join(overlay, 'eclass', eclass) + '.eclass'
- if os.path.isfile(path) and digest == osutils.MD5HashFile(path):
- return path
- raise NoMatchingFileForDigest(
- 'No matching eclass file found: %s %s' % (eclass, digest))
-
-
-def _parse_ebuild_cache_entry(cache_file_path):
- """Extract the eclasses with their digest from an ebuild's cache file."""
- eclass_regex = re.compile(r'_eclasses_=(.*)')
- eclass_clause_regex = (
- # The eclass name, e.g. cros-workon.
- r'(?P<eclass>[^\s]+)\s+'
- # The edb cache files contain the overlay path, the md5 cache file does
- # not, so optionally parse the path.
- r'((?P<overlay_path>[^\s]+)\s+)?'
- # The eclass digest followed by a word boundary -- \b prevents parsing md5
- # digests as paths when the next class begins with a-f.
- r'(?P<digest>[\da-fA-F]+)\b\s*')
-
- cachefile = osutils.ReadFile(cache_file_path)
- m = eclass_regex.search(cachefile)
- if not m:
- return []
-
- start, end = m.start(1), m.end(1)
- entries = re.finditer(eclass_clause_regex, cachefile[start:end])
- return [(c.group('eclass'), c.group('digest')) for c in entries]
+ return dependency_lib.normalize_source_paths(source_paths)
def GenerateSourcePathMapping(packages, sysroot_path, board):
@@ -188,88 +71,7 @@
For each source path which is a directory, the string is ended with a
trailing '/'.
"""
-
- results = {}
-
- packages_to_ebuild_paths = portage_util.FindEbuildsForPackages(
- packages, sysroot=sysroot_path, check=True)
-
- # Source paths which are the directory of ebuild files.
- for package, ebuild_path in packages_to_ebuild_paths.items():
- # Include the entire directory that contains the ebuild as the package's
- # FILESDIR probably lives there too.
- results[package] = [os.path.dirname(ebuild_path)]
-
- # Source paths which are cros workon source paths.
- buildroot = os.path.join(constants.CHROOT_SOURCE_ROOT, 'src')
- manifest = git.ManifestCheckout.Cached(buildroot)
- for package, ebuild_path in packages_to_ebuild_paths.items():
- attrs = portage_util.EBuild.Classify(ebuild_path)
- if (not attrs.is_workon or
- # Blacklisted ebuild is pinned to a specific git sha1, so change in
- # that repo matter to the ebuild.
- attrs.is_blacklisted):
- continue
- ebuild = portage_util.EBuild(ebuild_path)
- workon_subtrees = ebuild.GetSourceInfo(buildroot, manifest).subtrees
- for path in workon_subtrees:
- results[package].append(path)
-
- if board:
- overlay_directories = portage_util.FindOverlays(
- overlay_type='both', board=board)
- else:
- # If a board is not specified we assume the package is intended for the SDK
- # and so we use the overlays for the SDK builder.
- overlay_directories = portage_util.FindOverlays(
- overlay_type='both', board=constants.CHROOT_BUILDER_BOARD)
-
- eclass_path_cache = {}
-
- for package, ebuild_path in packages_to_ebuild_paths.items():
- eclass_paths = GetRelevantEclassesForEbuild(ebuild_path, eclass_path_cache,
- overlay_directories)
- results[package].extend(eclass_paths)
-
- # Source paths which are the overlay directories for the given board
- # (packages are board specific).
-
- # The only parts of the overlay that affect every package are the current
- # profile (which lives somewhere in the profiles/ subdir) and a top-level
- # make.conf (if it exists).
- profile_directories = [
- os.path.join(x, 'profiles') for x in overlay_directories
- ]
- make_conf_paths = [os.path.join(x, 'make.conf') for x in overlay_directories]
-
- # These directories *might* affect a build, so we include them for now to
- # be safe.
- metadata_directories = [
- os.path.join(x, 'metadata') for x in overlay_directories
- ]
- scripts_directories = [
- os.path.join(x, 'scripts') for x in overlay_directories
- ]
-
- for package in results:
- results[package].extend(profile_directories)
- results[package].extend(make_conf_paths)
- results[package].extend(metadata_directories)
- results[package].extend(scripts_directories)
- # The 'crosutils' repo potentially affects the build of every package.
- results[package].append(constants.CROSUTILS_DIR)
-
- # chromiumos-overlay specifies default settings for every target in
- # chromeos/config and so can potentially affect every board.
- for package in results:
- results[package].append(
- os.path.join(constants.CHROOT_SOURCE_ROOT,
- constants.CHROMIUMOS_OVERLAY_DIR, 'chromeos', 'config'))
-
- for p in results:
- results[p] = NormalizeSourcePaths(results[p])
-
- return results
+ return dependency_lib.get_source_path_mapping(packages, sysroot_path, board)
@functools.lru_cache()
diff --git a/service/dependency_unittest.py b/service/dependency_unittest.py
index 8214583..42369cf 100644
--- a/service/dependency_unittest.py
+++ b/service/dependency_unittest.py
@@ -7,12 +7,8 @@
from __future__ import print_function
-import os
-
from chromite.api.gen.chromiumos import common_pb2
-from chromite.lib import constants
from chromite.lib import cros_test_lib
-from chromite.lib import osutils
from chromite.service import dependency
pytestmark = cros_test_lib.pytestmark_inside_only
@@ -75,41 +71,6 @@
},
}
- def testNormalizeSourcePathsCollapsingSubPaths(self):
- self.assertEqual(
- dependency.NormalizeSourcePaths(
- ['/mnt/host/source/foo', '/mnt/host/source/ab/cd',
- '/mnt/host/source/foo/bar']),
- ['ab/cd', 'foo'])
-
- self.assertEqual(
- dependency.NormalizeSourcePaths(
- ['/mnt/host/source/foo/bar',
- '/mnt/host/source/ab/cd',
- '/mnt/host/source/foo/bar/..',
- '/mnt/host/source/ab/cde']),
- ['ab/cd', 'ab/cde', 'foo'])
-
- def testNormalizeSourcePathsFormatingDirectoryPaths(self):
- with osutils.TempDir() as tempdir:
- foo_dir = os.path.join(tempdir, 'foo')
- bar_baz_dir = os.path.join(tempdir, 'bar', 'baz')
- osutils.SafeMakedirs(os.path.join(tempdir, 'ab'))
- ab_cd_file = os.path.join(tempdir, 'ab', 'cd')
-
- osutils.SafeMakedirs(foo_dir)
- osutils.SafeMakedirs(bar_baz_dir)
- osutils.WriteFile(ab_cd_file, 'alphabet')
-
-
- expected_paths = [ab_cd_file, bar_baz_dir + '/', foo_dir + '/']
- expected_paths = [os.path.relpath(p, constants.CHROOT_SOURCE_ROOT) for
- p in expected_paths]
-
- self.assertEqual(
- dependency.NormalizeSourcePaths([foo_dir, ab_cd_file, bar_baz_dir]),
- expected_paths)
-
def testDeterminePackageRelevanceNotRelevant(self):
"""Test determine_package_relevance with no matching paths."""
src_paths = ['foo/bar/baz', 'foo/bar/b', 'foo/bar', 'bar/foo']
