commit e342fb16f98530bc8efd0abfedc5986a2c58478c
author Edward Lesmes <ehmaldonado@google.com> Fri Feb 05 00:35:54 2021 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Feb 05 00:35:54 2021 +0000
tree 3784e3dcc8e435f5bd7963d18bc18d0e5866f0d6
parent 680a6c37a0fbb29292576f142431f162cb3d814e

Don't suggest change author as reviewer.

Change-Id: Ie34fc34883b2c86fc134f10ded24b26a631886ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2676835
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index efcf429..0369f16 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1382,7 +1382,7 @@
         f for f in files
         if status[f] == owners_client.OwnersClient.INSUFFICIENT_REVIEWERS
       ]
-      owners = client.SuggestOwners(missing_files)
+      owners = client.SuggestOwners(missing_files, exclude=[self.GetAuthor()])
       if options.add_owners_to == 'TBR':
         assert isinstance(options.tbrs, list), options.tbrs
         options.tbrs.extend(owners)
@@ -4806,7 +4806,8 @@
 
   if options.batch:
     client = owners_client.DepotToolsClient(root, base_branch)
-    print('\n'.join(client.SuggestOwners(affected_files)))
+    print('\n'.join(
+        client.SuggestOwners(affected_files, exclude=[cl.GetAuthor()])))
     return 0
 
   owner_files = [f for f in affected_files if 'OWNERS' in os.path.basename(f)]

presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index bda8cc7..b5db7ca 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -1182,7 +1182,8 @@
     if tbr and affects_owners:
       output_list.append(output_fn('TBR for OWNERS files are ignored.'))
     if not input_api.is_committing:
-      suggested_owners = input_api.owners_client.SuggestOwners(missing_files)
+      suggested_owners = input_api.owners_client.SuggestOwners(
+          missing_files, exclude=[owner_email])
       output_list.append(output_fn('Suggested OWNERS: ' +
           '(Use "git-cl owners" to interactively select owners.)\n    %s' %
           ('\n    '.join(suggested_owners))))