commit 5c0073d54cf5bc3ad1e3aabbfccbeed21a1e5f67
author David James <davidjames@chromium.org> Wed Apr 03 08:48:52 2013 -0700
committer ChromeBot <chrome-bot@google.com> Wed Apr 03 16:34:41 2013 -0700
tree 5db934837a0f1ecfed19b8abdc1938b2b99cbaae
parent 5ce2d7b243cc99533867f47d249f9775cd5e149e

Disallow 'chromium-os:' in BUG field.

The chromium-os tracker is disallowed in favor of the chromium tracker.

BUG=chromium:226095
TEST=Try out the hook with valid and invalid commit messages.
Change-Id: I2b3b1531c9a4302b39170cc956d6a781f06d63f7
Reviewed-on: https://gerrit.chromium.org/gerrit/47238
Tested-by: David James <davidjames@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: David James <davidjames@chromium.org>

pre-upload.py

diff --git a/pre-upload.py b/pre-upload.py
index 5752d16..b4f00f7 100755
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -326,13 +326,17 @@
 
 def _check_change_has_bug_field(project, commit):
   """Check for a correctly formatted 'BUG=' field in the commit message."""
-  BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium|chromium-os):\d+)'
+  OLD_BUG_RE = r'\nBUG=.*chromium-os'
+  if re.search(OLD_BUG_RE, _get_commit_desc(commit)):
+    msg = ('The chromium-os bug tracker is now deprecated. Please use\n'
+           'the chromium tracker in your BUG= line now.')
+    return HookFailure(msg)
 
+  BUG_RE = r'\nBUG=([Nn]one|(chrome-os-partner|chromium):\d+)'
   if not re.search(BUG_RE, _get_commit_desc(commit)):
     msg = ('Changelist description needs BUG field (after first line):\n'
-           'BUG=chromium-os:9999 (for public tracker)\n'
+           'BUG=chromium:9999 (for public tracker)\n'
            'BUG=chrome-os-partner:9999 (for partner tracker)\n'
-           'BUG=chromium:9999 (for browser tracker)\n'
            'BUG=None')
     return HookFailure(msg)