Partially revert "Disable source file checks for src/third_party repos and reorder source file hooks"
This partially reverts commit e37fe1a907de01f11ae6523c890333b4a30e0513.
Source file checks are re-enabled for third party repos, but keep the reordering of the source file hooks.
BUG=None
TEST=uploaded this change
Change-Id: Iaaeb5cac871d69c4193b4b4e91cc820dfa61fe07
diff --git a/pre-upload.py b/pre-upload.py
index dde2680..02e08a2 100644
--- a/pre-upload.py
+++ b/pre-upload.py
@@ -25,8 +25,9 @@
]
COMMON_EXCLUDED_PATHS = [
- # don't do source file checks for all third_party projects for now
- r"/src/third_party/",
+ # avoid doing source file checks for kernel
+ r"/src/third_party/kernel/",
+ r"/src/third_party/kernel-next/",
r".*\bexperimental[\\\/].*",
r".*\b[A-Z0-9_]{2,}$",
r".*[\\\/]debian[\\\/]rules$",
@@ -190,6 +191,8 @@
def _check_no_tabs(project, commit):
"""Checks there are no unexpanded tabs."""
TAB_OK_PATHS = [
+ r"/src/third_party/u-boot/",
+ r"/src/third_party/u-boot-next/",
r".*\.ebuild$",
r".*\.eclass$",
r".*/[M|m]akefile$"
@@ -282,10 +285,10 @@
COMMON_HOOKS = [_check_change_has_bug_field,
_check_change_has_test_field,
_check_change_has_proper_changeid,
- _check_no_long_lines,
_check_no_stray_whitespace,
- _check_no_tabs,
- _check_license]
+ _check_no_long_lines,
+ _check_license,
+ _check_no_tabs]
def _setup_project_hooks():
"""Returns a dictionay of callbacks: dict[project] = [callback1, callback2]"""
