overlays: Disable touchpad wakeup for convertibles.
Unset the touchpad_wakeup USE flag in convertible boards'
overlays to instruct powerd to unconditionally disable
touchpad wakeup. These devices lack the ability to
dynamically disable wakeup when they're converted to tablet
mode while suspended.
This effectively undoes f4c9a4381c990, which removed custom
udev rules files installed by these boards' BSP packages,
but switches us to use an easier-to-maintain USE flag. It
also adds a bunch of boards that didn't have the udev rules
before but should've.
BUG=chromium:710472
TEST=emerged the power_manager package for kevin and
verified that
/lib/udev/rules.d/92-powerd-tags-no-touchpad-wakeup.rules
was installed
CQ-DEPEND=I56f4e965f556ca6a7d0852f83c35a10853c49ee3
Change-Id: I2b26cd20377ab08ceda1fe52b6a3536dcbd5b559
Reviewed-on: https://chromium-review.googlesource.com/477464
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
(cherry picked from commit 0b6967ecbec5aad49d8f6827b59f57df29b1d3c4)
Reviewed-on: https://chromium-review.googlesource.com/481863
Reviewed-by: Dan Erat <derat@chromium.org>
diff --git a/overlay-bob/profiles/base/make.defaults b/overlay-bob/profiles/base/make.defaults
index 78af788..2c83532 100644
--- a/overlay-bob/profiles/base/make.defaults
+++ b/overlay-bob/profiles/base/make.defaults
@@ -7,3 +7,7 @@
USE="${USE} bob"
USE="${USE} arc"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
diff --git a/overlay-caroline/make.conf b/overlay-caroline/make.conf
index f5fa770..c8b8451 100644
--- a/overlay-caroline/make.conf
+++ b/overlay-caroline/make.conf
@@ -17,3 +17,7 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
diff --git a/overlay-cave/make.conf b/overlay-cave/make.conf
index 20e4a5e..4942bd1 100644
--- a/overlay-cave/make.conf
+++ b/overlay-cave/make.conf
@@ -12,3 +12,7 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
diff --git a/overlay-clapper/make.conf b/overlay-clapper/make.conf
index 049b104..66b74e0 100644
--- a/overlay-clapper/make.conf
+++ b/overlay-clapper/make.conf
@@ -19,5 +19,9 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# TODO(bhthompson): change to -march=slm when supported by CrOS GCC
MARCH_TUNE="-march=corei7"
diff --git a/overlay-cyan/make.conf b/overlay-cyan/make.conf
index 3487a2d..89a5135 100644
--- a/overlay-cyan/make.conf
+++ b/overlay-cyan/make.conf
@@ -13,3 +13,7 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
diff --git a/overlay-elm/make.conf b/overlay-elm/make.conf
index cade273..e4388af 100644
--- a/overlay-elm/make.conf
+++ b/overlay-elm/make.conf
@@ -9,4 +9,8 @@
# NOTE: Deprecating feature. New board should NOT have it.
USE="${USE} allow_consumer_kiosk"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
EC_FIRMWARE="elm"
diff --git a/overlay-eve/make.conf b/overlay-eve/make.conf
index 4de0a16..ad47d4a 100644
--- a/overlay-eve/make.conf
+++ b/overlay-eve/make.conf
@@ -18,6 +18,10 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
LINUX_FIRMWARE="${LINUX_FIRMWARE} iwlwifi-7265D iwlwifi-7265 ibt-hw cros-pd"
MARCH_TUNE="-march=corei7"
diff --git a/overlay-glimmer/make.conf b/overlay-glimmer/make.conf
index 3db69ce..c73ce90 100644
--- a/overlay-glimmer/make.conf
+++ b/overlay-glimmer/make.conf
@@ -16,5 +16,9 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# TODO(bhthompson): change to -march=slm when supported by CrOS GCC
MARCH_TUNE="-march=corei7"
diff --git a/overlay-gru/profiles/base/make.defaults b/overlay-gru/profiles/base/make.defaults
index af66df9..e03ad01 100644
--- a/overlay-gru/profiles/base/make.defaults
+++ b/overlay-gru/profiles/base/make.defaults
@@ -8,6 +8,10 @@
USE="${USE} gru"
USE="${USE} arc"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# All firmwares to build from the EC code base
EC_FIRMWARE="gru"
diff --git a/overlay-hana/make.conf b/overlay-hana/make.conf
index f643406..623a593 100644
--- a/overlay-hana/make.conf
+++ b/overlay-hana/make.conf
@@ -3,4 +3,8 @@
# found in the LICENSE file.
USE="${USE} touchview"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
#EC_FIRMWARE="hana"
diff --git a/overlay-kevin/profiles/base/make.defaults b/overlay-kevin/profiles/base/make.defaults
index 38237e4..a1a1429 100644
--- a/overlay-kevin/profiles/base/make.defaults
+++ b/overlay-kevin/profiles/base/make.defaults
@@ -18,6 +18,10 @@
# NOTE: Deprecating feature. New board should NOT have it.
USE="${USE} allow_consumer_kiosk"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# All firmwares to build from the EC code base
EC_FIRMWARE="kevin"
diff --git a/overlay-nasher/profiles/base/make.defaults b/overlay-nasher/profiles/base/make.defaults
index 665d956..862f036 100644
--- a/overlay-nasher/profiles/base/make.defaults
+++ b/overlay-nasher/profiles/base/make.defaults
@@ -9,6 +9,10 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# Uncomment these lines to activate the serial port.
# TTY_CONSOLE="ttyS0"
# USE="${USE} pcserial"
diff --git a/overlay-pbody/make.conf b/overlay-pbody/make.conf
index d263783..d594f0f 100644
--- a/overlay-pbody/make.conf
+++ b/overlay-pbody/make.conf
@@ -6,3 +6,7 @@
# Use ext4 crypto
USE="${USE} direncryption"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
diff --git a/overlay-pyro/make.conf b/overlay-pyro/make.conf
index 088e719..dd58096 100644
--- a/overlay-pyro/make.conf
+++ b/overlay-pyro/make.conf
@@ -9,5 +9,9 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# All firmwares to build from the EC code base
EC_FIRMWARE="pyro"
diff --git a/overlay-reef/make.conf b/overlay-reef/make.conf
index 8f719af..9ebedce 100644
--- a/overlay-reef/make.conf
+++ b/overlay-reef/make.conf
@@ -9,6 +9,10 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# All firmwares to build from the EC code base
EC_FIRMWARE="reef"
diff --git a/overlay-snappy/make.conf b/overlay-snappy/make.conf
index a908632..c2179fd 100644
--- a/overlay-snappy/make.conf
+++ b/overlay-snappy/make.conf
@@ -8,6 +8,10 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# All firmwares to build from the EC code base
EC_FIRMWARE="snappy"
diff --git a/overlay-variant-veyron-minnie/make.conf b/overlay-variant-veyron-minnie/make.conf
index 29275d6..4ce8e33 100644
--- a/overlay-variant-veyron-minnie/make.conf
+++ b/overlay-variant-veyron-minnie/make.conf
@@ -17,5 +17,9 @@
# NOTE: Deprecating feature. New board should NOT have it.
USE="${USE} allow_consumer_kiosk"
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
+
# The EC board name is minnie
EC_FIRMWARE="minnie"
diff --git a/overlay-wizpig/make.conf b/overlay-wizpig/make.conf
index 13891cc..2d4409a 100644
--- a/overlay-wizpig/make.conf
+++ b/overlay-wizpig/make.conf
@@ -13,3 +13,7 @@
# Avoid inhibiting the keyboard (which reports events from side buttons).
USE="${USE} keyboard_includes_side_buttons"
+
+# Disable touchpad wakeup since it can't be turned off dynamically when the
+# system is converted to tablet mode while it's suspended.
+USE="${USE} -touchpad_wakeup"
